Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Vedang Patel <vedang.patel@intel.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
	marc.herbert@intel.com, Mark Brown <broonie@kernel.org>,
	liam.r.girdwood@intel.com, jeeja.kp@intel.com,
	subhransu.s.prusty@intel.com
Subject: Applied "ASoC: Intel: Skylake: Increase loglevel of debug messages." to the asoc tree
Date: Mon, 27 Jun 2016 17:40:21 +0100	[thread overview]
Message-ID: <E1bHZa9-0005Ci-D2@debutante> (raw)
In-Reply-To: <1461711790-7277-4-git-send-email-vedang.patel@intel.com>

The patch

   ASoC: Intel: Skylake: Increase loglevel of debug messages.

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 91c1832579700891747820862633f9a8d0d81fa4 Mon Sep 17 00:00:00 2001
From: Vedang Patel <vedang.patel@intel.com>
Date: Fri, 24 Jun 2016 17:37:11 -0700
Subject: [PATCH] ASoC: Intel: Skylake: Increase loglevel of debug messages.

There is log spam while doing playback, record or reloading the
audio firmware.

print_hex_dump uses printk(KERN_DEBUG,... which is different from
dev_dbg used elsewhere in the driver: it's always enabled at
compile-time. Change it to print_hex_dump_debug for logging consistency.

For consistency with other log statements, change dev_info to dev_dbg
for a kernel print which is frequently printed by the driver.

Signed-off-by: Vedang Patel <vedang.patel@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/skylake/skl-messages.c | 2 +-
 sound/soc/intel/skylake/skl-sst-ipc.c  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index 804091aa6e64..6902020df946 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -730,7 +730,7 @@ static int skl_set_module_format(struct skl_sst *ctx,
 
 	dev_dbg(ctx->dev, "Module type=%d config size: %d bytes\n",
 			module_config->id.module_id, param_size);
-	print_hex_dump(KERN_DEBUG, "Module params:", DUMP_PREFIX_OFFSET, 8, 4,
+	print_hex_dump_debug("Module params:", DUMP_PREFIX_OFFSET, 8, 4,
 			*param_data, param_size, false);
 	return 0;
 }
diff --git a/sound/soc/intel/skylake/skl-sst-ipc.c b/sound/soc/intel/skylake/skl-sst-ipc.c
index 543460293b00..c141f24cae05 100644
--- a/sound/soc/intel/skylake/skl-sst-ipc.c
+++ b/sound/soc/intel/skylake/skl-sst-ipc.c
@@ -363,7 +363,7 @@ static void skl_ipc_process_reply(struct sst_generic_ipc *ipc,
 	/* first process the header */
 	switch (reply) {
 	case IPC_GLB_REPLY_SUCCESS:
-		dev_info(ipc->dev, "ipc FW reply %x: success\n", header.primary);
+		dev_dbg(ipc->dev, "ipc FW reply %x: success\n", header.primary);
 		/* copy the rx data from the mailbox */
 		sst_dsp_inbox_read(ipc->dsp, msg->rx_data, msg->rx_size);
 		break;
@@ -692,7 +692,7 @@ int skl_ipc_init_instance(struct sst_generic_ipc *ipc,
 	 /* param_block_size must be in dwords */
 	u16 param_block_size = msg->param_data_size / sizeof(u32);
 
-	print_hex_dump(KERN_DEBUG, NULL, DUMP_PREFIX_NONE,
+	print_hex_dump_debug(NULL, DUMP_PREFIX_NONE,
 		16, 4, buffer, param_block_size, false);
 
 	header.primary = IPC_MSG_TARGET(IPC_MOD_MSG);
-- 
2.8.1

      parent reply	other threads:[~2016-06-27 16:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 22:08 [PATCH 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-04-12 22:08 ` [PATCH 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-04-13  1:09   ` Takashi Sakamoto
2016-04-14 15:15     ` Vedang Patel
2016-04-15 19:13       ` Vedang Patel
2016-04-12 22:08 ` [PATCH 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-27 16:40   ` Applied "ASoC: Intel: common: increase the loglevel of "FW Poll Status"." to the asoc tree Mark Brown
2016-04-12 22:08 ` [PATCH 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-04-26 23:03   ` [PATCH v2 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-04-26 23:03     ` [PATCH v2 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-04-26 23:03     ` [PATCH v2 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-04-26 23:03     ` [PATCH v2 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-01  1:14       ` [PATCH v3 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-06-01  1:14         ` [PATCH v3 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-06-27 16:40           ` Applied "ASoC: hdac_hdmi: Increase loglevel of hex dump printed" to the asoc tree Mark Brown
2016-06-01  1:15         ` [PATCH v3 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-01  1:15         ` [PATCH v3 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-01  5:56         ` [PATCH v3 0/3] ASoC: Reduce audio related kernel spew Vinod Koul
2016-06-25  0:37       ` [REPOST REPOST PATCH " vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-27 14:50         ` [REPOST REPOST PATCH v3 0/3] ASoC: Reduce audio related kernel spew Mark Brown
2016-06-29 23:39           ` Patel, Vedang
2016-06-30  2:27             ` Vinod Koul
2016-07-01  7:50               ` Mark Brown
2016-06-27 16:40       ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1bHZa9-0005Ci-D2@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=marc.herbert@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=vedang.patel@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox