From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C2C7C433DB for ; Thu, 7 Jan 2021 16:48:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE42022C9F for ; Thu, 7 Jan 2021 16:48:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE42022C9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 508741678; Thu, 7 Jan 2021 17:47:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 508741678 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610038097; bh=T4JV9RGym6W8KHChs3hbmT9y/UEjB4S59PeI0+GDSGU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CH3ytgnEJk9V7RTcUD8HTDK9RDwqNKv27XilzgGOb7RpgswAaK6wxIDAi2YZ20T90 Rg3DQPmkD9LkyLl/IelkBfY9/crgLxtalVMXvJcr5QEODwI/QxJCkP3QV7ZLPXAou0 HtemUN8+9GzqtRJ2HFr1+N5EeP5KyUjZc+KJQtkc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C5DFFF801F5; Thu, 7 Jan 2021 17:47:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8F93DF80258; Thu, 7 Jan 2021 17:47:24 +0100 (CET) Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C8EACF800FD for ; Thu, 7 Jan 2021 17:47:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C8EACF800FD Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gerhold.net header.i=@gerhold.net header.b="ZaywqVgT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1610038040; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:From: Subject:Sender; bh=X9XzwfzJf0RYI3CMdzGR9FkBLKJdmQnbMp6CNAxJCJA=; b=ZaywqVgTR+A1Tu0kG37pKVSJS8JCrw9DnW2hXLrDQiHUOI4Ym5Z6wZZbraUH2iuk/z 4lRmWFEmQvhji6AIe7gEOcj56YNrOtGrQPHN/LHl4HZzulKL/Pq7MixOUyqH2TgBjnTc PT8vChwptp9kWwhNuwozKPitI49r87A29xtxvriyRsEXE6orm6vkijIUZUFG2lIpRjwj UnFKZNGgdomCNCLcsL1SUt71WTIgTSAkqZCDR0qgY9NzrBGPwHLmmNmbvSMEfEqWymbJ WwgPB3AjuzEYRBbQmikFKAeJrgYkngZ8MKyKjuAwrzSHLIgwH6MR6geRnWMiSyWo5kPk 1eqg== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8jwIc/AY4o=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.12.1 DYNA|AUTH) with ESMTPSA id R0a218x07GlJ6Aw (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 7 Jan 2021 17:47:19 +0100 (CET) Date: Thu, 7 Jan 2021 17:47:16 +0100 From: Stephan Gerhold To: Mark Brown Subject: Re: [PATCH] ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack() Message-ID: References: <20210107162640.313859-1-stephan@gerhold.net> <20210107163600.GE4726@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107163600.GE4726@sirena.org.uk> Cc: alsa-devel@alsa-project.org, Srinivas Kandagatla , Liam Girdwood , Cheng-Yi Chiang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jan 07, 2021 at 04:36:00PM +0000, Mark Brown wrote: > On Thu, Jan 07, 2021 at 05:26:40PM +0100, Stephan Gerhold wrote: > > > However, hdmi_codec_set_jack() returns -E*OP*NOTSUPP if jack detection > > is not supported, which is not handled in apq8016_sbc and soc_component_ret(). > > Make it return -ENOTSUPP instead to fix sound and silence the errors. > > You will also need to update imx-hdmi, it is explicitly checking for > -EOPNOTSUPP so this will break it. Having two error codes with such > similar names is rather unfortunate. Right, thanks for mentioning this! Apparently I only checked 5.10 for other uses of -EOPNOTSUPP... Will send a v2 shortly! Thanks, Stephan