From: Mark Brown <broonie@kernel.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Takashi Iwai <tiwai@suse.com>,
Maxim Schwalm <maxim.schwalm@gmail.com>,
Dmitry Osipenko <digetx@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v1 04/10] ASoC: tegra: Support RT5631 by machine driver
Date: Wed, 22 Feb 2023 14:57:10 +0000 [thread overview]
Message-ID: <Y/YtRtSqFAQj+AZU@sirena.org.uk> (raw)
In-Reply-To: <Y/YYaVhE7WwqLIey@kadam>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Wed, Feb 22, 2023 at 04:28:09PM +0300, Dan Carpenter wrote:
> On Wed, Feb 22, 2023 at 09:55:52AM +0200, Svyatoslav Ryhel wrote:
> > вт, 21 лют. 2023 р. о 21:32 Dan Carpenter <error27@gmail.com> пише:
> > > > /* Mic Jack */
> > > This comment doesn't make sense now. It was never super useful, though.
> > > Just delete it.
> > It does. Headset is Mic Jack + Headphones combined. headset_check function
> > performs check for a Mic Jack component in plugged Jack 3.5
> I feel if we need to discuess what a comment means or if it even means
> anything then that's a useless comment by definition.
If the device doesn't have a distinct mic jack then it's not ideal to
talk about there being one (as opposed to the microphone on the headset
jack).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-22 14:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 18:32 [PATCH v1 00/10] Fix sound on ASUS Transformers Svyatoslav Ryhel
2023-02-21 18:32 ` [PATCH v1 01/10] dt-bindings: sound: nvidia,tegra-audio-common: add new property Svyatoslav Ryhel
2023-02-26 19:35 ` Rob Herring
2023-02-21 18:32 ` [PATCH v1 02/10] sound: soc: jack: allow multiple interrupt per gpio Svyatoslav Ryhel
2023-02-21 22:08 ` Mark Brown
2023-02-22 7:53 ` Svyatoslav Ryhel
2023-02-22 12:16 ` Mark Brown
2023-02-21 18:32 ` [PATCH v1 03/10] dt-bindings: sound: nvidia,tegra-audio: add RT5631 CODEC Svyatoslav Ryhel
2023-02-26 19:37 ` Rob Herring
2023-02-28 8:15 ` Krzysztof Kozlowski
2023-02-21 18:32 ` [PATCH v1 04/10] ASoC: tegra: Support RT5631 by machine driver Svyatoslav Ryhel
2023-02-21 19:32 ` Dan Carpenter
2023-02-22 7:55 ` Svyatoslav Ryhel
2023-02-22 13:28 ` Dan Carpenter
2023-02-22 14:57 ` Mark Brown [this message]
2023-02-21 22:23 ` Mark Brown
2023-02-22 8:00 ` Svyatoslav Ryhel
2023-02-22 12:17 ` Mark Brown
2023-02-21 18:32 ` [PATCH v1 05/10] dt-bindings: sound: nvidia,tegra-audio: add MAX9808x CODEC Svyatoslav Ryhel
2023-02-26 19:38 ` Rob Herring
2023-02-21 18:32 ` [PATCH v1 06/10] ASoC: tegra: Support MAX9808x by machine driver Svyatoslav Ryhel
2023-02-21 18:32 ` [PATCH v1 07/10] ARM: tegra: transformers: update bindings of sound graph Svyatoslav Ryhel
2023-02-21 22:26 ` Mark Brown
2023-02-22 8:02 ` Svyatoslav Ryhel
2023-02-22 12:19 ` Mark Brown
2023-02-21 18:32 ` [PATCH v1 08/10] dt-bindings: dsp: add Fortemedia FM34 DSP Svyatoslav Ryhel
2023-02-26 19:42 ` Rob Herring
2023-02-21 18:32 ` [PATCH v1 09/10] staging: dsp: add support for Fortemedia FM34NE DSP Svyatoslav Ryhel
2023-02-21 19:27 ` Greg Kroah-Hartman
2023-02-22 8:19 ` Svyatoslav Ryhel
2023-02-22 9:21 ` Greg Kroah-Hartman
2023-02-22 9:39 ` Святослав Ригель
2023-02-22 11:15 ` Greg Kroah-Hartman
2023-02-22 12:19 ` Mark Brown
2023-02-21 19:39 ` Dan Carpenter
2023-02-22 8:06 ` Svyatoslav Ryhel
2023-02-22 13:31 ` Dan Carpenter
2023-02-21 22:41 ` Mark Brown
2023-02-22 8:14 ` Svyatoslav Ryhel
2023-02-22 12:36 ` Mark Brown
2023-02-22 9:20 ` Claudiu.Beznea
2023-02-21 18:32 ` [PATCH v1 10/10] ARM: tegra: transformers: bind FM34NE DSP on supported devices Svyatoslav Ryhel
2023-03-06 13:31 ` (subset) [PATCH v1 00/10] Fix sound on ASUS Transformers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/YtRtSqFAQj+AZU@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=clamor95@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=maxim.schwalm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox