From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC781C433FE for ; Tue, 11 Oct 2022 06:04:10 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D54EE3699; Tue, 11 Oct 2022 08:03:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D54EE3699 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665468248; bh=F6whdzliCPX0Ut/5yxmInL6GnfLrONlsF+sP9Uqujzs=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mBFbShodurjoDBIZhEyGXjajZPu/RbdlQxkIKcfUg3cAl8B0WDm/7Ah11djwX7RP/ zB9jw8ZjQTMmF0g518g1gG7GftS54+hhrJhFNvzShPJEezDCCiyV1ms9T4C+QSIwNb SQPnayT5h6zbC9dFLcxZHLzhOTUzCTC3miXLEAoc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 09528F80542; Tue, 11 Oct 2022 08:02:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 14B27F80256; Tue, 11 Oct 2022 02:02:10 +0200 (CEST) Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 650ECF80107 for ; Tue, 11 Oct 2022 02:02:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 650ECF80107 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BMj8f33/" Received: by mail-pf1-x42c.google.com with SMTP id 204so12028698pfx.10 for ; Mon, 10 Oct 2022 17:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HDvDPLCLAPPvF5TVvL+FWbJtEqmbYVODvwDkJg3SqIo=; b=BMj8f33/fyuY4YUgfzIsC8MB079NtlG/lc5y1lSPpCGAsz+jvSYZCTpuRzKVZGf2GY nZi6ZRgOudbzROz6pHhHElsWmoKQQy847SVQHPP6Lzs+V2eA/brEnXLuDstKnq7MW7Ih TzHZfV7XKs3PD0GAaAkJAXCvXBlxf5lB+KS3lhnFICm9Tq4yaQhhQQax921FRXOWW/if /toe/pDvQON4HdgY5CGmbYgif/tTyjDjkjRdKQFAulnURnCwp8NMFdEBa3NYmPI0A+fB fhamlfjudZxMTaB+1mSMxDuObe1ocZe7cQbErJKQBTAEur2a0QkUbRoT5VJEglEdMX1y d2HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HDvDPLCLAPPvF5TVvL+FWbJtEqmbYVODvwDkJg3SqIo=; b=wM9XeDLflXZzWyVEUr8dI0ql/Sy7MTFrRC56OAxm5ARWzgOMxMTvsvg4L89R39z0zV t8YRecomrwI0An2sMwc7HjpSWjEnP7iYfY2mLcSDJ2QdCj7mDKg/nfnSqNA2qh/hwfG0 b/n60Ph/GX5qHSKfu2Oi1DZTwHjWw5T90HGkVrUwGw3fVOus7Yqc+H1ir+4xPCvTcqpm hDgMyO+Sr7zXnJmuM/FGAzWnYbxTDqwK92p+F3OiyHys0XEyFqkrieaiZJbBjXabLwRV 2z7YDgDMsCTNgyEiarcXqhcinRlcfc8EqiMu9z1QwSEVdeEtCO3MWLg/0kt+TU7Lagzq XYbA== X-Gm-Message-State: ACrzQf2bWt1OE11/E52UyerdEoz6s5PE7+QFhJszwpB3AOdURX5ikQdu tOCqylyCKBDMfaVuZqIUKb8= X-Google-Smtp-Source: AMsMyM7Y6pAnL5W1EJS9G7oSUu8S6FVrr9k2c5r6QKOELR9o0pNGH3yk7s3YJUqb5vMyZxDtzUjxCg== X-Received: by 2002:a63:4949:0:b0:442:b733:2fae with SMTP id y9-20020a634949000000b00442b7332faemr18227721pgk.424.1665446520354; Mon, 10 Oct 2022 17:02:00 -0700 (PDT) Received: from sol (110-174-58-111.static.tpgi.com.au. [110.174.58.111]) by smtp.gmail.com with ESMTPSA id v29-20020aa799dd000000b0056258a3606csm7454081pfi.215.2022.10.10.17.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 17:01:59 -0700 (PDT) Date: Tue, 11 Oct 2022 08:01:27 +0800 From: Kent Gibson To: Andy Shevchenko Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) Message-ID: References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> X-Mailman-Approved-At: Tue, 11 Oct 2022 08:02:20 +0200 Cc: Andrew Lunn , Tomer Maimon , Geert Uytterhoeven , Linus Walleij , Tomasz Figa , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Horatiu Vultur , Emil Renner Berthing , Phil Edworthy , linux-samsung-soc@vger.kernel.org, Samuel Holland , Michal Simek , Ludovic Desroches , NXP Linux Team , Tali Perry , Sascha Hauer , Thomas Gleixner , linux-omap@vger.kernel.org, Andy Shevchenko , Scott Branden , Andrew Jeffery , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Claudiu Beznea , alsa-devel@alsa-project.org, Alim Akhtar , linux-aspeed@lists.ozlabs.org, Thierry Reding , Viresh Kumar , Gregory Clement , Jonathan Hunter , Fabien Dessenne , linux-media@vger.kernel.org, Charles Keepax , linux-arm-msm@vger.kernel.org, Nicolas Ferre , linux-actions@lists.infradead.org, linux-gpio@vger.kernel.org, soc@kernel.org, linux-rpi-kernel@lists.infradead.org, Mika Westerberg , linux-arm-kernel@lists.infradead.org, Dong Aisheng , Damien Le Moal , linux-renesas-soc@vger.kernel.org, Maxime Coquelin , Jacky Bai , Basavaraj Natikar , Alexandre Belloni , Fabio Estevam , Florian Fainelli , Benjamin Fair , Nancy Yuen , Chen-Yu Tsai , Broadcom internal kernel review list , Joel Stanley , Chen-Yu Tsai , Orson Zhai , Patrice Chotard , Ray Jui , Richard Fitzgerald , Baolin Wang , Mauro Carvalho Chehab , Avi Fishman , Patrick Venture , Shawn Guo , Andreas =?iso-8859-1?Q?F=E4rber?= , Tony Lindgren , Konrad Dybcio , Alexandre Torgue , Bjorn Andersson , Paul Cercueil , Haojian Zhuang , linux-riscv@lists.infradead.org, Marc Zyngier , openbmc@lists.ozlabs.org, Kunihiko Hayashi , Prathamesh Shete , Andy Gross , Sebastian Hesselbarth , Manivannan Sadhasivam , Lad Prabhakar , Billy Tsai , linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, AngeloGioacchino Del Regno , patches@opensource.cirrus.com, Sean Wang , linux-mips@vger.kernel.org, Krzysztof Kozlowski , Chunyan Zhang , Dmitry Baryshkov , Shiraz Hashim , Bartosz Golaszewski X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote: > Do not imply that some of the generic headers may be always included. > Instead, include explicitly what we are direct user of. > > While at it, sort headers alphabetically. > > Signed-off-by: Andy Shevchenko > --- > drivers/gpio/gpiolib-cdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c > index f8041d4898d1..60a60e2d60c5 100644 > --- a/drivers/gpio/gpiolib-cdev.c > +++ b/drivers/gpio/gpiolib-cdev.c > @@ -10,8 +10,9 @@ > #include > #include > #include > -#include > #include > +#include > +#include Ok with the hte re-order. But moving the gpio subsystem header after the gpio/driver is not alphabetical ('.' precedes '/') and it read better and made more sense to me the way it was. > #include > #include > #include > @@ -20,11 +21,12 @@ > #include > #include > #include > +#include I wasn't aware that we use anything from seq_file. What am I missing? Cheers, Kent. > #include > #include > #include > #include > -#include > + > #include > > #include "gpiolib.h" > -- > 2.35.1 >