From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6D2DC433F5 for ; Tue, 11 Oct 2022 13:49:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 009DF3D07; Tue, 11 Oct 2022 15:48:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 009DF3D07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665496163; bh=QHbuyb2S/uUcVxyF/lwXUqAZuHdBPKm0sW+WbMyb3sc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cuGOPPTIJ4jnZmo17W97J50vPhyQxJR/p9gPPnfYKb+87cwp2ARlXhSps8Gpa1YjX hDUCgftEwyAbk24CopsmdY1WURTTbmzLvXaDFh3seB76XaT2LI59ntT4WsBIAuzAoO R2z9XEZd+/puOPPjkp3AL3aPxYU6kpVLE8iSRjCY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9A08BF801D5; Tue, 11 Oct 2022 15:48:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 46135F801D5; Tue, 11 Oct 2022 15:48:31 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C5D89F80134 for ; Tue, 11 Oct 2022 15:48:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C5D89F80134 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ENOWe+eE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665496109; x=1697032109; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QHbuyb2S/uUcVxyF/lwXUqAZuHdBPKm0sW+WbMyb3sc=; b=ENOWe+eEBzLII7vGMMwFBy8AMRlIXsCCP4Jf4oWWlKfBi2FWTSoiPa0S MGXjtXISDXpHTjLQnxFerlDiVT33He3AA0LT3faAk4RK4RyWxBeYmJJfR PQONIe8Q0R2ArJ91rWBVUCP6KAubrRxlawwglQoKvOHGCX98lRGf95UcE wwMtU4Y5gM8GuPeM34XWF8hmaNZYqyEbVPbVEgo5QFDFIwify4Mk8kMHr 8JqUX2QIWYN1CF4y1+nLXak4zK2CG/6o2NUSuis8orhp680+UPY8A/jCc BpVks+ZdOPN427LBn3nVvXZbBfAYVlyYIWcXSUgKdSm43NCYNNd0pvhaX A==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="390812142" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="390812142" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 06:48:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="695068698" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="695068698" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 11 Oct 2022 06:48:19 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oiFcH-005KIR-1Z; Tue, 11 Oct 2022 16:48:17 +0300 Date: Tue, 11 Oct 2022 16:48:17 +0300 From: Andy Shevchenko To: Kent Gibson Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) Message-ID: References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-aspeed@lists.ozlabs.org, patches@opensource.cirrus.com, Bartosz Golaszewski , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Oct 11, 2022 at 11:05:42AM +0300, Andy Shevchenko wrote: > On Tue, Oct 11, 2022 at 3:02 AM Kent Gibson wrote: > > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote: ... > > > -#include > > > #include > > > +#include > > > +#include > > > > Ok with the hte re-order. > > > > But moving the gpio subsystem header after the gpio/driver is not > > alphabetical ('.' precedes '/') and it read better and made more sense > > to me the way it was. > > I see, I guess this is vim sort vs shell sort. Strange, they should > follow the locale settings... I have checked, the shell and vim sort gave the same result as in this patch. -- With Best Regards, Andy Shevchenko