From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 210A8C4332F for ; Sat, 26 Nov 2022 08:00:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E81E817C9; Sat, 26 Nov 2022 08:59:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E81E817C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1669449610; bh=0dPBcIou1yq73/ShQ5ge15FFqP86cP4E6nEb250ZlWo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RFKTZE1V9L7488AjH5Zntyhu2O/Y7MSitIsgz/b0FoEA8A9gMS+m5KwClIa3ZcWVW CThlAUoGAijbpLMyCehZJFhOLpDdH5Pe6e7WOo/6lwD9JXnvFgE6WoFM/ERpEg2sKl Nz3JIo+7toF2MvpvokRbMNsPGN8bjM4N+dF8hmYo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 69124F80238; Sat, 26 Nov 2022 08:58:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CFC4DF8025D; Wed, 23 Nov 2022 14:35:16 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 31236F80115 for ; Wed, 23 Nov 2022 14:35:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 31236F80115 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MdlsoDD+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669210514; x=1700746514; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0dPBcIou1yq73/ShQ5ge15FFqP86cP4E6nEb250ZlWo=; b=MdlsoDD+g5aYaafCzytjg85ZZZe6YPgBDTPEsAlecCFvKz7rTimiamYd 3Z+uUA4gmD6xi+GqVXapvajJcF6ZBiiNT1EzweEj1R/24kFt1pAqEoGmL X03QYh2L+3TFK5BfcTrAtZzhU7pi00tt+ji6wCoTkUoIBz1eGNDMFoUNl yqYcErtLhkbU36QGHyEeGtZspKQRXuazyIwJ+qYRLe9BQ/07IpRQStcvs qE7n6tp18P9jUBA4HHJT7BslWWX2gM8JmkaKM4We9EFyqblM7pry3zVIh yDn/KGINluiqBhj20MqslPgVghpbs996BOrkN1IIAGADVnIkzdF8rj1L5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="301624491" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="301624491" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 05:35:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="970863671" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="970863671" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 23 Nov 2022 05:35:00 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oxptw-00GImp-12; Wed, 23 Nov 2022 15:34:56 +0200 Date: Wed, 23 Nov 2022 15:34:56 +0200 From: Andy Shevchenko To: Maximilian Luz Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Mailman-Approved-At: Sat, 26 Nov 2022 08:58:51 +0100 Cc: Alexandre Belloni , Heikki Krogerus , Sean Young , "Rafael J. Wysocki" , alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org, Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Bard Liao , Dan Williams , linux-acpi@vger.kernel.org, Frank Rowand , Pierre-Louis Bossart , "Matthew Wilcox \(Oracle\)" , Jason Gunthorpe , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Won Chung , Len Brown , devicetree@vger.kernel.org, Chaitanya Kulkarni , Ira Weiny , Michael Jamet , Ming Lei , Mark Gross , Hans de Goede , Rob Herring , Jiri Slaby , Thomas Gleixner , Mauro Carvalho Chehab , Mika Westerberg , Jens Axboe , linux-block@vger.kernel.org, Jilin Yuan , "Martin K. Petersen" , Greg Kroah-Hartman , Dmitry Torokhov , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , Sakari Ailus , Yehezkel Bernat , Sanyog Kale , linux-media@vger.kernel.org, linux-usb@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Nov 23, 2022 at 02:14:31PM +0100, Maximilian Luz wrote: > On 11/23/22 13:25, Greg Kroah-Hartman wrote: > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. [...] > > -static inline struct ssam_device *to_ssam_device(struct device *d) > > +static inline struct ssam_device *to_ssam_device(const struct device *d) > > { > > return container_of(d, struct ssam_device, dev); > > } > > I am slightly conflicted about this change as that now more or less > implicitly drops the const. So I'm wondering if it wouldn't be better to > either create a function specifically for const pointers or to just > open-code it in the instance above. > > I guess we could also convert this to a macro. Then at least there > wouldn't be an explicit and potentially misleading const-conversion > indicated in the function signature. This is an intermediate step as far as I know since moving container_of to recognize const is a bit noisy right now. I guess you can find a discussion on the topic between Greg and Sakari. -- With Best Regards, Andy Shevchenko