From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8782DC54EBD for ; Thu, 12 Jan 2023 16:01:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 493B092D8; Thu, 12 Jan 2023 17:00:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 493B092D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673539305; bh=z0ZYgHqL1YLvYl+ue5zNy1KMy+u3shk6BmiAvHiQZSA=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=sqtFu9tZs6iNR5SZIfxCd6TIpdLHuX0vVvZOHKXNAPyK6vOEtjgTKFj/rsPZfa40H HIlTpFlBl35ZMR3liPcKW/d3PuLT4E9WO5ZSBVJfiS+YGgCCpFuhlBWnGGJMuTo3+w Q0FemfRu+oVSRUmF3RrJ9GXFGIvABL4zvsEDKZqI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C8158F80549; Thu, 12 Jan 2023 16:59:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1F4CF8030F; Wed, 11 Jan 2023 10:51:35 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E47A7F8026A for ; Wed, 11 Jan 2023 10:51:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E47A7F8026A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xZGcZ5JD Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 756AF61B8A; Wed, 11 Jan 2023 09:51:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54F6DC433F1; Wed, 11 Jan 2023 09:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673430685; bh=z0ZYgHqL1YLvYl+ue5zNy1KMy+u3shk6BmiAvHiQZSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xZGcZ5JDRrdXTJbt9tLPDzh24ToBaCeG04aIrg63SxaV0mqioT6pGZXGHiVeh9ZOU sO0JuLfJTFUVrJVMPgoU9Fwio7tkoa1uh4VeY/xzIKAbqvAAsfPDw+kuuk3E42lxBv sJ9yu85to26aoTWWeVLBJDsI3mtwYFGQ3RchmYyA= Date: Wed, 11 Jan 2023 10:51:22 +0100 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 12 Jan 2023 16:59:42 +0100 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heikki Krogerus , Sean Young , alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org, Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Bard Liao , Dan Williams , Andy Shevchenko , linux-acpi@vger.kernel.org, Frank Rowand , Pierre-Louis Bossart , "Matthew Wilcox \(Oracle\)" , Jason Gunthorpe , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Won Chung , Len Brown , devicetree@vger.kernel.org, Chaitanya Kulkarni , Ira Weiny , Michael Jamet , Ming Lei , Mark Gross , Hans de Goede , Rob Herring , Jiri Slaby , Thomas Gleixner , Mauro Carvalho Chehab , Mika Westerberg , Jens Axboe , linux-block@vger.kernel.org, Jilin Yuan , "Martin K. Petersen" , Dmitry Torokhov , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , Sakari Ailus , Yehezkel Bernat , Sanyog Kale , linux-media@vger.kernel.org, Maximilian Luz , linux-usb@vger.kernel.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Nov 23, 2022 at 01:38:05PM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 23, 2022 at 1:25 PM Greg Kroah-Hartman > wrote: > > > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Stefan Richter > > Cc: Wolfram Sang > > Cc: Alexandre Belloni > > Cc: Dmitry Torokhov > > Cc: Sean Young > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Vinod Koul > > Cc: Bard Liao > > Cc: Pierre-Louis Bossart > > Cc: Sanyog Kale > > Cc: Andreas Noever > > Cc: Michael Jamet > > Cc: Mika Westerberg > > Cc: Yehezkel Bernat > > Cc: Jiri Slaby > > Cc: Heikki Krogerus > > Cc: "Matthew Wilcox (Oracle)" > > Cc: "Martin K. Petersen" > > Cc: Chaitanya Kulkarni > > Cc: Ming Lei > > Cc: Jilin Yuan > > Cc: Alan Stern > > Cc: Andy Shevchenko > > Cc: Sakari Ailus > > Cc: Jason Gunthorpe > > Cc: Thomas Gleixner > > Cc: Ira Weiny > > Cc: Dan Williams > > Cc: Won Chung > > Cc: alsa-devel@alsa-project.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-acpi@vger.kernel.org > > Cc: linux-block@vger.kernel.org > > Cc: linux-i2c@vger.kernel.org > > Cc: linux-i3c@lists.infradead.org > > Cc: linux-input@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-serial@vger.kernel.org > > Cc: linux-usb@vger.kernel.org > > Cc: linux1394-devel@lists.sourceforge.net > > Cc: platform-driver-x86@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Rafael J. Wysocki > > (which my ACPI maintainer hat on). thanks for the review, I'll add it to the v2 patch. greg k-h