From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 557F3C54EBD for ; Fri, 13 Jan 2023 15:44:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4A2B7ABDD; Fri, 13 Jan 2023 16:44:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4A2B7ABDD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1673624690; bh=RDtldCHhOU3Bo3pJibaZpOM4uT1+p0yui2PnCg+as8o=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=bwa3bx9kaQJHyESWMZBfBzrRCW/Ez+yz3jzCi+ULhzge5phMjoZgsFuG1khk1lfjt bX99WXYhwc8wzw5gIpjBmAFAvkilwdFzhQKe4OeiPlZ0yhK08lMj7UtXAZq0XDqc6w 0mCTCXvDllzd4PaRcwC3KCbkBmgO/1SvGBkCVQ2A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 09723F8019B; Fri, 13 Jan 2023 16:44:00 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9F24BF8030F; Fri, 13 Jan 2023 16:43:58 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B7543F8019B for ; Fri, 13 Jan 2023 16:43:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B7543F8019B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ONzkQ7gZ Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D0E10B82121; Fri, 13 Jan 2023 15:43:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD5D1C433F1; Fri, 13 Jan 2023 15:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673624633; bh=RDtldCHhOU3Bo3pJibaZpOM4uT1+p0yui2PnCg+as8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ONzkQ7gZ51JUMsLapq5pmDiXaYOsJLLKodE1n30W6DeD/hxkiGhdhnuDXGP90YlbB JSI9yUyvBZb3c/HDy6J4IQU80Ff8wPYSMi+gmsG4rZWTUwkdOG3YqVNsK35QKS5SvD /pVuMIR7QPeHSFYlgmpFIzfAUvBV3uYCbkPFXmZw= Date: Fri, 13 Jan 2023 16:43:19 +0100 From: Greg KH To: Takashi Iwai Subject: Re: [PATCH 5.10.y] ALSA: pcm: Properly take rwsem lock in ctl_elem_read_user/ctl_elem_write_user to prevent UAF Message-ID: References: <20230113142639.4420-1-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113142639.4420-1-tiwai@suse.de> X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Clement Lecigne Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jan 13, 2023 at 03:26:39PM +0100, Takashi Iwai wrote: > From: Clement Lecigne > > [ Note: this is a fix that works around the bug equivalently as the > two upstream commits: > 1fa4445f9adf ("ALSA: control - introduce snd_ctl_notify_one() helper") > 56b88b50565c ("ALSA: pcm: Move rwsem lock inside snd_ctl_elem_read to prevent UAF") > but in a simpler way to fit with older stable trees -- tiwai ] Thanks for the backport, now queued up. greg k-h