From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 184EFC00A5A for ; Thu, 19 Jan 2023 17:00:02 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C1FC31EF; Thu, 19 Jan 2023 17:59:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C1FC31EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674147599; bh=RF7r/yCO3++XGdA6LiIF6KXulOuZEe98+/7LlxVZQH0=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=HjSaVc+g6GdPdYsorqd/9WNUyLY6JAwVrWtU2uNSV8lDXsuiiaGr9RPGMkQgrSRmT 6GgcVQpF/FArG4bX4WN7SRFi3a42m0yalRBMYw0AudSZL72p/RlC3NghuUcbgsmxgd Ekvbaz+cpATedSPtvdTXTbfpgWavs0fi8/z0nh98= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6A957F8025D; Thu, 19 Jan 2023 17:59:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 14803F8047B; Thu, 19 Jan 2023 17:59:08 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 64054F80083 for ; Thu, 19 Jan 2023 17:59:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 64054F80083 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=GQoiqCvp Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FD4961CC1; Thu, 19 Jan 2023 16:59:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85341C433F1; Thu, 19 Jan 2023 16:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674147544; bh=RF7r/yCO3++XGdA6LiIF6KXulOuZEe98+/7LlxVZQH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GQoiqCvpDUa/QybJ5jQbTus0Ja3L42zIp3CXFNNBQP4Xlnb9lds2RMM4gFocuVpGj qLy1YiCfZsavYjAE+nNIy6OGPmZ2X8GKk1bXMUs7LGVxGkWCEKGwq18iMqs5SZPTpn Vyq3aImgkKElrrDXpMiW49C1q+HsPz1eP3DndMul2VfU3bwK1YEgrpd+/3TEMzpzmZ jmNwSEV0ARGnsnjvz84OOUFXkTZ32MTLsc5WOR1H0MTa9jQJ7cxeQZZvxYSdMSoQEp AsLy9GuTBDWnaNuXGdvsZIxi8PWneHED/nUbbJP2g7Em2Bnq54PaH6AvsG7ovcq9io 0OT8HHx2A5GZQ== Date: Thu, 19 Jan 2023 16:59:00 +0000 From: Mark Brown To: Arnd Bergmann Subject: Re: [PATCH 1/5] ASoC: samsung: remove DMA filter function and data Message-ID: References: <20230118161110.521504-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bzVt0O2u5Oo2htJ5" Content-Disposition: inline In-Reply-To: <20230118161110.521504-1-arnd@kernel.org> X-Cookie: What is the sound of one hand clapping? X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Charles Keepax , Arnd Bergmann , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --bzVt0O2u5Oo2htJ5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 18, 2023 at 05:10:45PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > This data is no longer passed by the platform code, so > there is no point passing it down at all. This breaks an x86 allmodconfig build: /build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c: In function =E2=80=98s3= c24xx_iis_dev_probe=E2=80=99: /build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:436:56: error: passing a= rgument 4 of =E2=80=98samsung_asoc_dma_platform_register=E2=80=99 from inco= mpatible pointer type [-Werror=3Dincompatible-pointer-types] 436 | "tx", "rx", NULL); | ^~~~ | | | char * In file included from /build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:21: /build/stage/linux/sound/soc/samsung/dma.h:17:55: note: expected =E2=80=98s= truct device *=E2=80=99 but argument is of type =E2=80=98char *=E2=80=99 17 | struct device *dma_dev); | ~~~~~~~~~~~~~~~^~~~~~~ /build/stage/linux/sound/soc/samsung/s3c24xx-i2s.c:435:15: error: too many = arguments to function =E2=80=98samsung_asoc_dma_platform_register=E2=80=99 435 | ret =3D samsung_asoc_dma_platform_register(&pdev->dev, NULL, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/samsung/dma.h:15:5: note: declared here 15 | int samsung_asoc_dma_platform_register(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --bzVt0O2u5Oo2htJ5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPJdtQACgkQJNaLcl1U h9DgjwgAgU0/cJsXAH8jVFRez5j0+Ywfwgj3yHcHuFoz+nMGVyWiantq0Ngpc4hl A2xXiyPAUihszEWIB8CsTZZ6QkinxuTVzhvCfZsBHP9cxv4N+wLUkCEZyFof1V9T Y260keksOWfsGEv2j4kiwf/sjEUp7rpiBhRal7Anf3wB9RDRuRhEVTIIWXqoFfZd l4NnvS9Nzis5VdmtlUd9mmz3EOPZ/MCjeaZk3Su5Wq4B2tCxxR3zhINn6Fugkk7p pF4BzZvVHKiO2TACVEd22dyF4Jl5e7tDnFNaWB4SVr8AyKg4XbPxJueIoNp0Ix80 vwaqN+MsmKDjZvMhsU4KsP9HmfzP9w== =aHDc -----END PGP SIGNATURE----- --bzVt0O2u5Oo2htJ5--