From: Mark Brown <broonie@kernel.org>
To: Kiseok Jo <kiseok.jo@irondevice.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: irondevice,sma1303: Rework binding and add missing properties
Date: Fri, 3 Feb 2023 13:37:13 +0000 [thread overview]
Message-ID: <Y90OCX002gLuf+Jx@sirena.org.uk> (raw)
In-Reply-To: <20230203094239.25700-1-kiseok.jo@irondevice.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Fri, Feb 03, 2023 at 09:42:37AM +0000, Kiseok Jo wrote:
> + sys-clk-id:
> + description:
> + select the using system clock.
> + 0 = External Clock 19.2MHz
> + 1 = External Clock 24.576MHz
> + 2 = Using PLL in MCLK
> + 3 = Using PLL in BCLK
> + $ref: "/schemas/types.yaml#/definitions/uint32"
> + maximum: 3
> + default: 3
We really shouldn't have this as a custom property, we should be using
a combination of the clock bindings.
In the driver this would turn into using clk_get() to get the MCLK, then
we can query the rate with clk_get_rate() and use option 0 or 1 if the
rate matches, or the PLL otherwise. If we fail to get MCLK then we can
fall back to using BCLK.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-03 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 9:42 [PATCH 1/3] ASoC: dt-bindings: irondevice, sma1303: Rework binding and add missing properties Kiseok Jo
2023-02-03 9:42 ` [PATCH 2/3] ASoC: SMA1303: Remove the I2C Retry property in devicetree Kiseok Jo
2023-02-03 9:42 ` [PATCH 3/3] ASoC: SMA1303: Convert the TDM slot properties in devicetree to mixer Kiseok Jo
2023-02-03 13:37 ` Mark Brown [this message]
2023-02-04 1:20 ` [PATCH 1/3] ASoC: dt-bindings: irondevice, sma1303: Rework binding and add missing properties Ki-Seok Jo
2023-02-03 22:01 ` [PATCH 1/3] ASoC: dt-bindings: irondevice,sma1303: " Rob Herring
2023-02-04 1:17 ` [PATCH 1/3] ASoC: dt-bindings: irondevice, sma1303: " Ki-Seok Jo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y90OCX002gLuf+Jx@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=kiseok.jo@irondevice.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox