From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 09/25] ASoC: rt: use helper function
Date: Mon, 30 Jan 2023 14:18:11 +0000 [thread overview]
Message-ID: <Y9fRoxR1E/OdmLvN@sirena.org.uk> (raw)
In-Reply-To: <87lelsu1gz.wl-kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
On Tue, Jan 24, 2023 at 02:10:20AM +0000, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current ASoC has many helper function.
> This patch use it.
This breaks an x86 allmodconfig build (missing use of the helper):
/build/stage/linux/sound/soc/codecs/rt1318-sdw.c: In function ‘rt1318_set_sdw_stream’:
/build/stage/linux/sound/soc/codecs/rt1318-sdw.c:578:12: error: ‘struct snd_soc_dai’ has no member named ‘stream’
578 | dai->stream[direction].dma_data = stream;
| ^~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:252: sound/soc/codecs/rt1318-sdw.o] Error 1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-30 14:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 2:07 [PATCH v2 00/25] ASoC: use helper function and cleanup Kuninori Morimoto
2023-01-24 2:07 ` [PATCH v2 01/25] ASoC: soc-dai.h: add missing snd_soc_dai_set_widget() Kuninori Morimoto
2023-01-24 2:07 ` [PATCH v2 02/25] ASoC: soc-dai.h: add snd_soc_dai_dma_data_set/get() for low level Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 03/25] ASoC: soc-dai.h: add snd_soc_dai_tdm_mask_set/get() helper Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 04/25] ASoC: soc-dai.h: add snd_soc_dai_get/set_widget_playback/capture() helper Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 05/25] ASoC: soc.h: add snd_soc_card_is_instantiated() helper Kuninori Morimoto
2023-01-24 2:08 ` [PATCH v2 06/25] ASoC: hdmi-codec: use helper function Kuninori Morimoto
2023-01-24 2:09 ` [PATCH v2 07/25] ASoC: hda: " Kuninori Morimoto
2023-01-24 2:09 ` [PATCH v2 08/25] ASoC: max: " Kuninori Morimoto
2023-01-24 2:10 ` [PATCH v2 09/25] ASoC: rt: " Kuninori Morimoto
2023-01-30 14:18 ` Mark Brown [this message]
2023-01-24 2:10 ` [PATCH v2 10/25] ASoC: cirrus: " Kuninori Morimoto
2023-01-24 2:11 ` [PATCH v2 11/25] ASoC: spear: " Kuninori Morimoto
2023-01-24 2:11 ` [PATCH v2 12/25] ASoC: sdw-mockup: " Kuninori Morimoto
2023-01-24 2:12 ` [PATCH v2 13/25] ASoC: intel: " Kuninori Morimoto
2023-01-24 2:12 ` [PATCH v2 14/25] ASoC: mediatek: " Kuninori Morimoto
2023-01-24 11:03 ` AngeloGioacchino Del Regno
2023-01-24 2:13 ` [PATCH v2 15/25] ASoC: meson: " Kuninori Morimoto
2023-01-24 9:29 ` Jerome Brunet
2023-01-24 2:13 ` [PATCH v2 16/25] ASoC: rockchip: " Kuninori Morimoto
2023-01-24 2:14 ` [PATCH v2 17/25] ASoC: sof: " Kuninori Morimoto
2023-01-24 2:14 ` [PATCH v2 18/25] ASoC: tegra: " Kuninori Morimoto
2023-01-24 2:15 ` [PATCH v2 19/25] ASoC: ti: " Kuninori Morimoto
2023-01-24 2:15 ` [PATCH v2 20/25] ASoC: soc-core.c: " Kuninori Morimoto
2023-01-24 2:15 ` [PATCH v2 21/25] ASoC: soc-dapm.c: " Kuninori Morimoto
2023-01-24 2:16 ` [PATCH v2 22/25] ASoC: soc-dai.c: " Kuninori Morimoto
2023-01-24 2:16 ` [PATCH v2 23/25] ASoC: soc-pcm.c: " Kuninori Morimoto
2023-01-24 2:17 ` [PATCH v2 24/25] ASoC: soc-topology.c: " Kuninori Morimoto
2023-01-24 2:17 ` [PATCH v2 25/25] ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai Kuninori Morimoto
2023-01-31 22:17 ` [PATCH v2 00/25] ASoC: use helper function and cleanup Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9fRoxR1E/OdmLvN@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox