From: Greg KH <gregkh@linuxfoundation.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@linaro.org,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, hui.wang@canonical.com,
vkoul@kernel.org, srinivas.kandagatla@linaro.org,
sanyog.r.kale@intel.com, rander.wang@linux.intel.com,
bard.liao@intel.com
Subject: Re: [PATCH] soundwire: intel: move to auxiliary bus
Date: Tue, 23 Mar 2021 08:37:27 +0100 [thread overview]
Message-ID: <YFmatyAoMZmBmkuZ@kroah.com> (raw)
In-Reply-To: <20210323004325.19727-1-yung-chuan.liao@linux.intel.com>
On Tue, Mar 23, 2021 at 08:43:25AM +0800, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Now that the auxiliary_bus exists, there's no reason to use platform
> devices as children of a PCI device any longer.
>
> This patch refactors the code by extending a basic auxiliary device
> with Intel link-specific structures that need to be passed between
> controller and link levels. This refactoring is much cleaner with no
> need for cross-pointers between device and link structures.
>
> Note that the auxiliary bus API has separate init and add steps, which
> requires more attention in the error unwinding paths. The main loop
> needs to deal with kfree() and auxiliary_device_uninit() for the
> current iteration before jumping to the common label which releases
> everything allocated in prior iterations.
The init/add steps can be moved together in the aux bus code if that
makes this usage simpler. Please do that instead.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-23 7:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 0:43 [PATCH] soundwire: intel: move to auxiliary bus Bard Liao
2021-03-23 6:48 ` Vinod Koul
2021-03-23 7:37 ` Greg KH
2021-03-23 17:29 ` Pierre-Louis Bossart
2021-03-24 10:50 ` Vinod Koul
2021-03-24 15:03 ` Pierre-Louis Bossart
2021-03-23 7:37 ` Greg KH [this message]
2021-03-23 18:04 ` Pierre-Louis Bossart
2021-03-23 18:32 ` Greg KH
2021-03-23 19:14 ` Pierre-Louis Bossart
2021-03-24 9:30 ` Greg KH
2021-03-24 14:55 ` Pierre-Louis Bossart
2021-03-24 15:36 ` Greg KH
2021-03-26 16:24 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFmatyAoMZmBmkuZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=hui.wang@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox