From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E45C433B4 for ; Sun, 25 Apr 2021 06:16:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 679A66147F for ; Sun, 25 Apr 2021 06:16:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 679A66147F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F00EC1765; Sun, 25 Apr 2021 08:15:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F00EC1765 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619331368; bh=auP6JRuummQkkVZR1IcxBPxBUP5jCkGA0V99FK4ibXQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r42fESiTkA6s3K+U2ydGh9SzoeqdfY9Wly6ztkizcOlJZMc+i4K1apmogKXJjqxDr eiLp2vYGpVU1/v/3ogIZZEi2EkI0QTgMUkN3dQLylirJlevb+UqC3RLd7tFSbUBy0+ Gp8rSpoClFk87QC3TO41vsLrNC7p2N/3R9/cigac= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6DB72F801D8; Sun, 25 Apr 2021 08:15:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BA1E9F801EC; Sun, 25 Apr 2021 08:15:11 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F2F35F800E3 for ; Sun, 25 Apr 2021 08:15:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F2F35F800E3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BSZo7B0z" Received: by mail.kernel.org (Postfix) with ESMTPSA id 742AD6124B; Sun, 25 Apr 2021 06:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619331300; bh=auP6JRuummQkkVZR1IcxBPxBUP5jCkGA0V99FK4ibXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BSZo7B0ztK/ZJ6b9ewVhX1tiYoKt2aVWLM9tzkidgo8bd4NahwbZgSelW2qjvkeVA 4Cuf22JgyanY8g/eHylN+oOyZzH/JbOFwp+a8b6jGIdQW2D6lhpPLcxUewADOVt59p BfKGkxp270f1RqpnNZxbM7mATC8gj00Vgsj6eMUA= Date: Sun, 25 Apr 2021 08:14:53 +0200 From: Greg Kroah-Hartman To: Shawn Guo Subject: Re: [PATCH] firmware: replace HOTPLUG with UEVENT in FW_ACTION defines Message-ID: References: <20210425020024.28057-1-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210425020024.28057-1-shawn.guo@linaro.org> Cc: alsa-devel@alsa-project.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Lee Jones , Mauro Carvalho Chehab , linux-scsi@vger.kernel.org, James Smart , linux-serial@vger.kernel.org, linux-media@vger.kernel.org, Ohad Ben-Cohen , Dick Kennedy , Arnd Bergmann , Mark Brown , Bjorn Andersson , Kalle Valo , Timur Tabi , Mathieu Poirier , linux-wireless@vger.kernel.org, Liam Girdwood , Vinod Koul , Stuart Hayes , dmaengine@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, Apr 25, 2021 at 10:00:24AM +0800, Shawn Guo wrote: > With commit 312c004d36ce ("[PATCH] driver core: replace "hotplug" by > "uevent"") already in the tree over a decade, update the name of > FW_ACTION defines to follow semantics, and reflect what the defines are > really meant for, i.e. whether or not generate user space event. > > Signed-off-by: Shawn Guo > --- > drivers/dma/imx-sdma.c | 2 +- > drivers/media/platform/exynos4-is/fimc-is.c | 2 +- > drivers/mfd/iqs62x.c | 2 +- > drivers/misc/lattice-ecp3-config.c | 2 +- > drivers/net/wireless/ti/wlcore/main.c | 2 +- > drivers/platform/x86/dell/dell_rbu.c | 2 +- > drivers/remoteproc/remoteproc_core.c | 2 +- > drivers/scsi/lpfc/lpfc_init.c | 2 +- > drivers/tty/serial/ucc_uart.c | 2 +- > include/linux/firmware.h | 4 ++-- > lib/test_firmware.c | 10 +++++----- > sound/soc/codecs/wm8958-dsp2.c | 6 +++--- > 12 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index d5590c08db51..e2b559945c11 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1829,7 +1829,7 @@ static int sdma_get_firmware(struct sdma_engine *sdma, > int ret; > > ret = request_firmware_nowait(THIS_MODULE, > - FW_ACTION_HOTPLUG, fw_name, sdma->dev, > + FW_ACTION_UEVENT, fw_name, sdma->dev, Naming is hard :) I can take this after -rc1, but really, is it needed? What problem does this renaming solve? Who is the current name confusing? thanks, greg k-h