From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3867C48BE8 for ; Mon, 14 Jun 2021 04:43:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95306613AD for ; Mon, 14 Jun 2021 04:43:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95306613AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 94338176F; Mon, 14 Jun 2021 06:43:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 94338176F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623645833; bh=aI8cMZgT9nGkbzOwk4swnaCdK6M1OPDEIveCp5UKvNo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HJwtFsoFe6feEF3pP9lVnGOD71YBmsI6LuQCcib91Z9pXLLoKJzQw1e9eTzPpKHuV goomvoSAu17Le2gLDpd5SpQsA2j4LhYvpMFaMRQdytVV7XwFDEAqCW6so/ENTydB9U 16t961Fey12pRd4if2S7dMWmRdZ6/BFs54LlAdag= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 169DEF800F7; Mon, 14 Jun 2021 06:43:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 19BEBF8023C; Mon, 14 Jun 2021 06:43:01 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B6AE0F800F7 for ; Mon, 14 Jun 2021 06:42:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B6AE0F800F7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kswggof0" Received: by mail.kernel.org (Postfix) with ESMTPSA id 9502161283; Mon, 14 Jun 2021 04:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623645766; bh=aI8cMZgT9nGkbzOwk4swnaCdK6M1OPDEIveCp5UKvNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kswggof0QOHxDsakxaZXl6U0LzceZK1TdqpkxcrKI1jHBW1YQAft7E6cax7/dq8ko 7PQFW2M1QtmoD9dWaKPA3lFOEA/jPcsD6Q52XB4/9AbBNXLGNQnPsKqKOjl92czxs6 tKoMfvKzIZZqoHvBEUUvuBnnw+0PAwq32gY21xf3POd1PT494EQmYZO7PuvH4mp6GW kVifhMaGcYO+PwSup8nWtUf4yiy4Q8iinBa0XR6Xf3y2mSNOT7CFKAZiajAcigeUhD vAYiHeLQ9LqgZoII0ylrke+YDVxiONz/Ro1kppRHEWvXSthsAUgQC1t19OaFl8OlfN 2pTViCBwh3XFw== Date: Mon, 14 Jun 2021 10:12:42 +0530 From: Vinod Koul To: Bard Liao Subject: Re: [PATCH v4] soundwire: intel: move to auxiliary bus Message-ID: References: <20210511052132.28150-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511052132.28150-1-yung-chuan.liao@linux.intel.com> Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, hui.wang@canonical.com, sanyog.r.kale@intel.com, rander.wang@linux.intel.com, bard.liao@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11-05-21, 13:21, Bard Liao wrote: > From: Pierre-Louis Bossart > > Now that the auxiliary_bus exists, there's no reason to use platform > devices as children of a PCI device any longer. > > This patch refactors the code by extending a basic auxiliary device > with Intel link-specific structures that need to be passed between > controller and link levels. This refactoring is much cleaner with no > need for cross-pointers between device and link structures. > > Note that the auxiliary bus API has separate init and add steps, which > requires more attention in the error unwinding paths. The main loop > needs to deal with kfree() and auxiliary_device_uninit() for the > current iteration before jumping to the common label which releases > everything allocated in prior iterations. Applied, thanks -- ~Vinod