From: Vinod Koul <vkoul@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org,
pierre-louis.bossart@linux.intel.com,
linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
rander.wang@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH] soundwire: bus: filter out more -EDATA errors on clock stop
Date: Thu, 22 Jul 2021 19:47:02 +0530 [thread overview]
Message-ID: <YPl93hm715Nm6ZEe@matsya> (raw)
In-Reply-To: <20210714014209.17357-1-yung-chuan.liao@linux.intel.com>
On 14-07-21, 09:42, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> We've added quite a few filters to avoid throwing errors if a Device
> does not respond to commands during the clock stop sequences, but we
> missed one.
>
> This will lead to an isolated message
> [ 6115.294412] soundwire sdw-master-1: SDW_SCP_STAT bread failed:-61
>
> The callers already filter this error code, so there's no point in
> keeping it at the lower level.
>
> Since this is a recoverable error, make this dev_err() conditional and
> only log cases with Command Failed.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-07-22 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 1:42 [PATCH] soundwire: bus: filter out more -EDATA errors on clock stop Bard Liao
2021-07-22 14:17 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPl93hm715Nm6ZEe@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).