* [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values
@ 2021-07-14 1:30 Bard Liao
2021-07-22 14:14 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Bard Liao @ 2021-07-14 1:30 UTC (permalink / raw)
To: alsa-devel, vkoul
Cc: vinod.koul, gregkh, pierre-louis.bossart, linux-kernel,
sanyog.r.kale, rander.wang, bard.liao
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sparse throws the following type of warnings:
drivers/soundwire/dmi-quirks.c:25:17: error: constant
0x000010025D070100 is so big it is long
Let's add the 'ull' suffix to make this go away and find real issues.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Paul Olaru <paul.olaru@oss.nxp.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/dmi-quirks.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c
index 5db0a2443a1d..1ac16687e315 100644
--- a/drivers/soundwire/dmi-quirks.c
+++ b/drivers/soundwire/dmi-quirks.c
@@ -22,12 +22,12 @@ struct adr_remap {
*/
static const struct adr_remap hp_spectre_360[] = {
{
- 0x000010025D070100,
- 0x000020025D071100
+ 0x000010025D070100ull,
+ 0x000020025D071100ull
},
{
- 0x000110025d070100,
- 0x000120025D130800
+ 0x000110025d070100ull,
+ 0x000120025D130800ull
},
{}
};
@@ -39,18 +39,18 @@ static const struct adr_remap hp_spectre_360[] = {
static const struct adr_remap dell_sku_0A3E[] = {
/* rt715 on link0 */
{
- 0x00020025d071100,
- 0x00021025d071500
+ 0x00020025d071100ull,
+ 0x00021025d071500ull
},
/* rt711 on link1 */
{
- 0x000120025d130800,
- 0x000120025d071100,
+ 0x000120025d130800ull,
+ 0x000120025d071100ull,
},
/* rt1308 on link2 */
{
- 0x000220025d071500,
- 0x000220025d130800
+ 0x000220025d071500ull,
+ 0x000220025d130800ull
},
{}
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values
2021-07-14 1:30 [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values Bard Liao
@ 2021-07-22 14:14 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-07-22 14:14 UTC (permalink / raw)
To: Bard Liao
Cc: alsa-devel, gregkh, pierre-louis.bossart, linux-kernel,
sanyog.r.kale, rander.wang, bard.liao
On 14-07-21, 09:30, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Sparse throws the following type of warnings:
>
> drivers/soundwire/dmi-quirks.c:25:17: error: constant
> 0x000010025D070100 is so big it is long
>
> Let's add the 'ull' suffix to make this go away and find real issues.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-22 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-14 1:30 [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values Bard Liao
2021-07-22 14:14 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).