From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FB6C4338F for ; Thu, 19 Aug 2021 13:27:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6645361151 for ; Thu, 19 Aug 2021 13:27:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6645361151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1C6DD1679; Thu, 19 Aug 2021 15:26:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1C6DD1679 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629379661; bh=PQKS7ifiKL5AQ+28N4ttww+q8yDryty2pNVgBMcPytM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gZsiKp4BKUBTVz6pprRQY5PFSMLzaoEFJUmMqDmUZt4azRn2M6OpvgLA4JfZK0Sdx Pb3p3APBNLdSu4XfZhgUviCn2cqH5NzUzABThAFJc2trYD30iEtjE3iXANDOuQxagT yFpRH76TthkNdZEfhUJ0Zkg4QQYiRpNgKijH6ojI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 93089F800F8; Thu, 19 Aug 2021 15:26:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5C057F8026D; Thu, 19 Aug 2021 15:26:47 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A6CE7F800F8 for ; Thu, 19 Aug 2021 15:26:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A6CE7F800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tycrSuyO" Received: by mail.kernel.org (Postfix) with ESMTPSA id 6259E60C40; Thu, 19 Aug 2021 13:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629379595; bh=PQKS7ifiKL5AQ+28N4ttww+q8yDryty2pNVgBMcPytM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tycrSuyOSNYl1aTSKDaJEM7Mq5BYIH3GS8sAOKgYCNSQLxbpEvRzzholgpUhN6vmj vgt7YP9sgB8H49kOHC9V+ANMjbMvJHcPHJrlSr9Ex2ADGopBwhbuUUMZrcfkG0gMDH ISEUc8/ZdqBVyN232BucS+SxFLLUJTBQOek8uAIwhyIvYS3ztxCcHOxO6Yldq94EHF 5uueggVbebDyajNm4f42tNzlSXCLguWsAW3Gbc5c76Le8r9mcf11CB/HbkQmaof6jS PvIybP/IT3rJ6nk5Dd8iWBLi21jz70AnZM5EV0ZLiXxF8f2+oDG4qb49vgkHwyXMnN Erbk1h2KWub/w== Date: Thu, 19 Aug 2021 09:26:34 -0400 From: Sasha Levin To: Charles Keepax Subject: Re: [PATCH AUTOSEL 5.13 03/12] ASoC: wm_adsp: Let soc_cleanup_component_debugfs remove debugfs Message-ID: References: <20210817003536.83063-1-sashal@kernel.org> <20210817003536.83063-3-sashal@kernel.org> <20210818131544.GL9223@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210818131544.GL9223@ediswmail.ad.cirrus.com> Cc: alsa-devel@alsa-project.org, Lucas Tanure , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Aug 18, 2021 at 01:15:44PM +0000, Charles Keepax wrote: >On Mon, Aug 16, 2021 at 08:35:27PM -0400, Sasha Levin wrote: >> From: Lucas Tanure >> >> [ Upstream commit acbf58e530416e167c3b323111f4013d9f2b0a7d ] >> >> soc_cleanup_component_debugfs will debugfs_remove_recursive >> the component->debugfs_root, so adsp doesn't need to also >> remove the same entry. >> By doing that adsp also creates a race with core component, >> which causes a NULL pointer dereference >> >> Signed-off-by: Lucas Tanure >> Link: https://lore.kernel.org/r/20210728104416.636591-1-tanureal@opensource.cirrus.com >> Signed-off-by: Mark Brown >> Signed-off-by: Sasha Levin >> --- >> sound/soc/codecs/wm_adsp.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c >> index cef05d81c39b..6698b5343974 100644 >> --- a/sound/soc/codecs/wm_adsp.c >> +++ b/sound/soc/codecs/wm_adsp.c >> @@ -746,7 +746,6 @@ static void wm_adsp2_init_debugfs(struct wm_adsp *dsp, >> static void wm_adsp2_cleanup_debugfs(struct wm_adsp *dsp) >> { >> wm_adsp_debugfs_clear(dsp); >> - debugfs_remove_recursive(dsp->debugfs_root); >> } > >It might be better not to backport this patch to the stable >kernels. The issue has only been seen on one out of tree driver >and the patch looks a little off to me. This >debugfs_remove_recursive should run before the >soc_cleanup_component_debugfs one, and as such it's hard to see >what is actually going on. We are currently investigating internally >but we might end up reverting the change, and it only seems to be >causing issues on the one not upstreamed part. > >Apologies for missing the review of this one when it went up >Mark, I was on holiday at the time. I'll drop it, it didn't go anywhere yet :) Thanks! -- Thanks, Sasha