* [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding
[not found] <20210901091852.479202-1-maxime@cerno.tech>
@ 2021-09-01 9:18 ` Maxime Ripard
2021-09-01 10:11 ` Charles Keepax
2021-09-01 14:39 ` Mark Brown
2021-09-01 9:18 ` [PATCH v2 02/52] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Maxime Ripard @ 2021-09-01 9:18 UTC (permalink / raw)
To: devicetree, Rob Herring, Frank Rowand, Chen-Yu Tsai,
Maxime Ripard, Jernej Škrabec
Cc: Rob Herring, alsa-devel, patches, Liam Girdwood, linux-sunxi,
Mark Brown, linux-arm-kernel
Even though we had the wm8978 driver for some time and a number of
boards using it already, we never had a binding for it. Let's add it
based on what the driver expects and the boards are providing.
Cc: alsa-devel@alsa-project.org
Cc: devicetree@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: patches@opensource.cirrus.com
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
Changes from v1:
- Changed the maintainers of the bindings
---
.../devicetree/bindings/sound/wlf,wm8978.yaml | 58 +++++++++++++++++++
1 file changed, 58 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
new file mode 100644
index 000000000000..944e5859c962
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8978.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Wolfson WM8978 Codec Device Tree Bindings
+
+maintainers:
+ - patches@opensource.cirrus.com
+
+properties:
+ '#sound-dai-cells':
+ const: 0
+
+ compatible:
+ const: wlf,wm8978
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 526000
+
+required:
+ - '#sound-dai-cells'
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ codec@0 {
+ #sound-dai-cells = <0>;
+ compatible = "wlf,wm8978";
+ reg = <0>;
+ spi-max-frequency = <500000>;
+ };
+ };
+
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ codec@0 {
+ #sound-dai-cells = <0>;
+ compatible = "wlf,wm8978";
+ reg = <0>;
+ };
+ };
+
+...
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding
2021-09-01 9:18 ` [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
@ 2021-09-01 10:11 ` Charles Keepax
2021-09-01 14:39 ` Mark Brown
1 sibling, 0 replies; 9+ messages in thread
From: Charles Keepax @ 2021-09-01 10:11 UTC (permalink / raw)
To: Maxime Ripard
Cc: devicetree, alsa-devel, Rob Herring, patches, Mark Brown,
linux-sunxi, Jernej Škrabec, Liam Girdwood, Chen-Yu Tsai,
Rob Herring, Frank Rowand, linux-arm-kernel
On Wed, Sep 01, 2021 at 11:18:01AM +0200, Maxime Ripard wrote:
> Even though we had the wm8978 driver for some time and a number of
> boards using it already, we never had a binding for it. Let's add it
> based on what the driver expects and the boards are providing.
>
> Cc: alsa-devel@alsa-project.org
> Cc: devicetree@vger.kernel.org
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: patches@opensource.cirrus.com
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding
2021-09-01 9:18 ` [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
2021-09-01 10:11 ` Charles Keepax
@ 2021-09-01 14:39 ` Mark Brown
2021-09-03 10:37 ` Maxime Ripard
1 sibling, 1 reply; 9+ messages in thread
From: Mark Brown @ 2021-09-01 14:39 UTC (permalink / raw)
To: Maxime Ripard
Cc: devicetree, alsa-devel, Rob Herring, patches, linux-sunxi,
Jernej Škrabec, Liam Girdwood, Chen-Yu Tsai, Rob Herring,
Frank Rowand, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Wed, Sep 01, 2021 at 11:18:01AM +0200, Maxime Ripard wrote:
> Even though we had the wm8978 driver for some time and a number of
> boards using it already, we never had a binding for it. Let's add it
> based on what the driver expects and the boards are providing.
What's the story with dependencies here? I don't have a cover letter or
anything and there seem to be a bunch of tangentially related patches in
a series here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding
2021-09-01 14:39 ` Mark Brown
@ 2021-09-03 10:37 ` Maxime Ripard
2021-09-03 11:36 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Maxime Ripard @ 2021-09-03 10:37 UTC (permalink / raw)
To: Mark Brown
Cc: devicetree, alsa-devel, Rob Herring, patches, linux-sunxi,
Jernej Škrabec, Liam Girdwood, Chen-Yu Tsai, Rob Herring,
Frank Rowand, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
Hi Mark,
On Wed, Sep 01, 2021 at 03:39:50PM +0100, Mark Brown wrote:
> On Wed, Sep 01, 2021 at 11:18:01AM +0200, Maxime Ripard wrote:
> > Even though we had the wm8978 driver for some time and a number of
> > boards using it already, we never had a binding for it. Let's add it
> > based on what the driver expects and the boards are providing.
>
> What's the story with dependencies here? I don't have a cover letter or
> anything and there seem to be a bunch of tangentially related patches in
> a series here.
There's no dependency, you can pick the ASoC patches safely
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding
2021-09-03 10:37 ` Maxime Ripard
@ 2021-09-03 11:36 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2021-09-03 11:36 UTC (permalink / raw)
To: Maxime Ripard
Cc: devicetree, alsa-devel, Rob Herring, patches, linux-sunxi,
Jernej Škrabec, Liam Girdwood, Chen-Yu Tsai, Rob Herring,
Frank Rowand, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On Fri, Sep 03, 2021 at 12:37:06PM +0200, Maxime Ripard wrote:
> On Wed, Sep 01, 2021 at 03:39:50PM +0100, Mark Brown wrote:
> > What's the story with dependencies here? I don't have a cover letter or
> > anything and there seem to be a bunch of tangentially related patches in
> > a series here.
> There's no dependency, you can pick the ASoC patches safely
Oh, OK. In cases like this it's generally better to not combine random
unrelated stuff into one series - as well as making it look like there
are dependencies it can also cause problems for tooling (eg, b4 is going
to want to fetch the whole series and my personal tooling doesn't like
the same series going to more than one of the subsystems I maintain.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 02/52] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema
[not found] <20210901091852.479202-1-maxime@cerno.tech>
2021-09-01 9:18 ` [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
@ 2021-09-01 9:18 ` Maxime Ripard
2021-09-03 17:52 ` Rob Herring
2021-09-01 9:18 ` [PATCH v2 03/52] ASoC: dt-bindings: Convert SPDIF Transmitter " Maxime Ripard
2021-09-01 9:18 ` [PATCH v2 04/52] ASoC: dt-bindings: Convert Simple Amplifier " Maxime Ripard
3 siblings, 1 reply; 9+ messages in thread
From: Maxime Ripard @ 2021-09-01 9:18 UTC (permalink / raw)
To: devicetree, Rob Herring, Frank Rowand, Chen-Yu Tsai,
Maxime Ripard, Jernej Škrabec
Cc: alsa-devel, Samuel Holland, Liam Girdwood, linux-sunxi,
Mark Brown, linux-arm-kernel
Bluetooth SCO Link are supported by Linux with a matching device tree
binding.
Now that we have the DT validation in place, let's convert the device
tree bindings for that driver over to a YAML schema.
Cc: alsa-devel@alsa-project.org
Cc: devicetree@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Samuel Holland <samuel@sholland.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
Changes from v1:
- Accept either a 0 or 1 #sound-dai-cells
---
.../devicetree/bindings/sound/bt-sco.txt | 13 -------
.../bindings/sound/linux,bt-sco.yaml | 38 +++++++++++++++++++
2 files changed, 38 insertions(+), 13 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/bt-sco.txt
create mode 100644 Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
diff --git a/Documentation/devicetree/bindings/sound/bt-sco.txt b/Documentation/devicetree/bindings/sound/bt-sco.txt
deleted file mode 100644
index 641edf75e184..000000000000
--- a/Documentation/devicetree/bindings/sound/bt-sco.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-Bluetooth-SCO audio CODEC
-
-This device support generic Bluetooth SCO link.
-
-Required properties:
-
- - compatible : "delta,dfbmcs320" or "linux,bt-sco"
-
-Example:
-
-codec: bt_sco {
- compatible = "delta,dfbmcs320";
-};
diff --git a/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml b/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
new file mode 100644
index 000000000000..e3a1f485f664
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/linux,bt-sco.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bluetooth SCO Audio Codec Device Tree Bindings
+
+maintainers:
+ - Mark Brown <broonie@kernel.org>
+
+properties:
+ '#sound-dai-cells':
+ enum:
+ - 0
+
+ # For Wideband PCM
+ - 1
+
+ compatible:
+ enum:
+ - delta,dfbmcs320
+ - linux,bt-sco
+
+required:
+ - '#sound-dai-cells'
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ codec {
+ #sound-dai-cells = <0>;
+ compatible = "linux,bt-sco";
+ };
+
+...
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 02/52] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema
2021-09-01 9:18 ` [PATCH v2 02/52] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
@ 2021-09-03 17:52 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2021-09-03 17:52 UTC (permalink / raw)
To: Maxime Ripard
Cc: devicetree, alsa-devel, Samuel Holland, linux-sunxi,
Liam Girdwood, Jernej Škrabec, Chen-Yu Tsai, Rob Herring,
Mark Brown, Frank Rowand, linux-arm-kernel
On Wed, 01 Sep 2021 11:18:02 +0200, Maxime Ripard wrote:
> Bluetooth SCO Link are supported by Linux with a matching device tree
> binding.
>
> Now that we have the DT validation in place, let's convert the device
> tree bindings for that driver over to a YAML schema.
>
> Cc: alsa-devel@alsa-project.org
> Cc: devicetree@vger.kernel.org
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Samuel Holland <samuel@sholland.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> Changes from v1:
> - Accept either a 0 or 1 #sound-dai-cells
> ---
> .../devicetree/bindings/sound/bt-sco.txt | 13 -------
> .../bindings/sound/linux,bt-sco.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/bt-sco.txt
> create mode 100644 Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 03/52] ASoC: dt-bindings: Convert SPDIF Transmitter binding to a schema
[not found] <20210901091852.479202-1-maxime@cerno.tech>
2021-09-01 9:18 ` [PATCH v2 01/52] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
2021-09-01 9:18 ` [PATCH v2 02/52] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
@ 2021-09-01 9:18 ` Maxime Ripard
2021-09-01 9:18 ` [PATCH v2 04/52] ASoC: dt-bindings: Convert Simple Amplifier " Maxime Ripard
3 siblings, 0 replies; 9+ messages in thread
From: Maxime Ripard @ 2021-09-01 9:18 UTC (permalink / raw)
To: devicetree, Rob Herring, Frank Rowand, Chen-Yu Tsai,
Maxime Ripard, Jernej Škrabec
Cc: Rob Herring, alsa-devel, Liam Girdwood, linux-sunxi, Mark Brown,
linux-arm-kernel
The SPDIF Transmitter binding is used by Linux with a matching Device
Tree binding.
Now that we have the DT validation in place, let's convert the device
tree bindings for that driver over to a YAML schema.
Cc: alsa-devel@alsa-project.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
.../bindings/sound/linux,spdif-dit.yaml | 32 +++++++++++++++++++
.../bindings/sound/spdif-transmitter.txt | 10 ------
2 files changed, 32 insertions(+), 10 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
delete mode 100644 Documentation/devicetree/bindings/sound/spdif-transmitter.txt
diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml b/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
new file mode 100644
index 000000000000..c6b070e1d014
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/linux,spdif-dit.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dummy SPDIF Transmitter Device Tree Bindings
+
+maintainers:
+ - Mark Brown <broonie@kernel.org>
+
+properties:
+ compatible:
+ const: linux,spdif-dit
+
+ "#sound-dai-cells":
+ const: 0
+
+required:
+ - "#sound-dai-cells"
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ spdif-out {
+ #sound-dai-cells = <0>;
+ compatible = "linux,spdif-dit";
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/spdif-transmitter.txt b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
deleted file mode 100644
index 55a85841dd85..000000000000
--- a/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-Device-Tree bindings for dummy spdif transmitter
-
-Required properties:
- - compatible: should be "linux,spdif-dit".
-
-Example node:
-
- codec: spdif-transmitter {
- compatible = "linux,spdif-dit";
- };
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 04/52] ASoC: dt-bindings: Convert Simple Amplifier binding to a schema
[not found] <20210901091852.479202-1-maxime@cerno.tech>
` (2 preceding siblings ...)
2021-09-01 9:18 ` [PATCH v2 03/52] ASoC: dt-bindings: Convert SPDIF Transmitter " Maxime Ripard
@ 2021-09-01 9:18 ` Maxime Ripard
3 siblings, 0 replies; 9+ messages in thread
From: Maxime Ripard @ 2021-09-01 9:18 UTC (permalink / raw)
To: devicetree, Rob Herring, Frank Rowand, Chen-Yu Tsai,
Maxime Ripard, Jernej Škrabec
Cc: Rob Herring, alsa-devel, Liam Girdwood, linux-sunxi, Mark Brown,
linux-arm-kernel, Jerome Brunet
Simple audio amplifiers are supported by Linux with a matching device
tree binding.
Now that we have the DT validation in place, let's convert the device
tree bindings for that driver over to a YAML schema.
Cc: alsa-devel@alsa-project.org
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
.../bindings/sound/simple-amplifier.txt | 17 -------
.../sound/simple-audio-amplifier.yaml | 45 +++++++++++++++++++
2 files changed, 45 insertions(+), 17 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/simple-amplifier.txt
create mode 100644 Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
diff --git a/Documentation/devicetree/bindings/sound/simple-amplifier.txt b/Documentation/devicetree/bindings/sound/simple-amplifier.txt
deleted file mode 100644
index b1b097cc9b68..000000000000
--- a/Documentation/devicetree/bindings/sound/simple-amplifier.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Simple Amplifier Audio Driver
-
-Required properties:
-- compatible : "dioo,dio2125" or "simple-audio-amplifier"
-
-Optional properties:
-- enable-gpios : the gpio connected to the enable pin of the simple amplifier
-- VCC-supply : power supply for the device, as covered
- in Documentation/devicetree/bindings/regulator/regulator.txt
-
-Example:
-
-amp: analog-amplifier {
- compatible = "simple-audio-amplifier";
- VCC-supply = <®ulator>;
- enable-gpios = <&gpio GPIOH_3 0>;
-};
diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
new file mode 100644
index 000000000000..26379377a7ac
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/simple-audio-amplifier.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Simple Audio Amplifier Device Tree Bindings
+
+maintainers:
+ - Jerome Brunet <jbrunet@baylibre.com>
+
+properties:
+ compatible:
+ enum:
+ - dioo,dio2125
+ - simple-audio-amplifier
+
+ enable-gpios:
+ maxItems: 1
+
+ VCC-supply:
+ description: >
+ power supply for the device
+
+ sound-name-prefix:
+ $ref: /schemas/types.yaml#/definitions/string
+ description: >
+ See ./name-prefix.txt
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/meson8-gpio.h>
+
+ analog-amplifier {
+ compatible = "simple-audio-amplifier";
+ VCC-supply = <®ulator>;
+ enable-gpios = <&gpio GPIOH_3 0>;
+ };
+
+...
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread