From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 150E4C433EF for ; Wed, 6 Oct 2021 16:25:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 921DC60F6C for ; Wed, 6 Oct 2021 16:25:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 921DC60F6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3112B9F6; Wed, 6 Oct 2021 18:25:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3112B9F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633537555; bh=n60Wzv1t8EOq1ed5DS9y50Ht6vJQjDXH6BuErsXsDmM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r7HLi7Ti9dTkdrq2azNv67T4Bi+wT+CxFj3Xbg9LYoyP3OQUeGX9+XhlsXd6ZcXjQ 9nzXHAePOH9zqba7zLOscU2qOXat/I2j8qQjLp/xKFZivPhaM9jC1xnzYw6Wdi7oKZ M2F0mQ/703MH/fCejV5AumVBm1QW7NNHAFigjKnM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C6999F80240; Wed, 6 Oct 2021 18:24:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 48BE0F80249; Wed, 6 Oct 2021 18:24:52 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9145AF8010B for ; Wed, 6 Oct 2021 18:24:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9145AF8010B X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="224808559" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="224808559" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:24:45 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="713002556" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:24:41 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mY9ie-009Fpl-Qk; Wed, 06 Oct 2021 19:24:36 +0300 Date: Wed, 6 Oct 2021 19:24:36 +0300 From: Andy Shevchenko To: Pierre-Louis Bossart Subject: Re: [PATCH v1 3/4] ASoC: Intel: bytcr_rt5640: use devm_clk_get_optional() for mclk Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-3-andriy.shevchenko@linux.intel.com> <31338a32-a870-4bf8-52ba-5204109cf974@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31338a32-a870-4bf8-52ba-5204109cf974@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: Cezary Rojewski , Takashi Iwai , Jie Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood , Hans de Goede , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Oct 06, 2021 at 10:54:12AM -0500, Pierre-Louis Bossart wrote: > On 10/6/21 10:04 AM, Andy Shevchenko wrote: > > The devm_clk_get_optional() helper returns NULL when devm_clk_get() > > returns -ENOENT. This makes things slightly cleaner. The added benefit > > is mostly cosmetic. ... > > if (SND_SOC_DAPM_EVENT_ON(event)) { > > - if (byt_rt5640_quirk & BYT_RT5640_MCLK_EN) { > > same comment as for rt5651, I don't see the point of removing the test > on this quirk? Same answers. -- With Best Regards, Andy Shevchenko