From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com
Subject: Re: [PATCH 2/4] ASoC: codecs: wcd934x: remove redundant ret variable
Date: Tue, 30 Nov 2021 16:37:21 +0000 [thread overview]
Message-ID: <YaZTQVP6YMFZcSVI@sirena.org.uk> (raw)
In-Reply-To: <8279f250-59cc-368d-13aa-b46cc3cb108e@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
On Tue, Nov 30, 2021 at 04:33:38PM +0000, Srinivas Kandagatla wrote:
>
>
> On 30/11/2021 16:31, Mark Brown wrote:
> > On Tue, Nov 30, 2021 at 04:05:05PM +0000, Srinivas Kandagatla wrote:
> > > return value form snd_soc_dapm_put_enum_double() directly instead
> > > of taking this in another redundant variable.
> > Cleanups like this should come after any fixes in a series.
> Noted, do you want me to resend a v2 fixing the order?
It should be fine, I'll let you know if it's needed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-30 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:05 [PATCH 0/4] ASoC: codecs: Qualcomm codecs fix kcontrol put return values Srinivas Kandagatla
2021-11-30 16:05 ` [PATCH 1/4] ASoC: codecs: wcd934x: handle channel mappping list correctly Srinivas Kandagatla
2021-11-30 16:05 ` [PATCH 2/4] ASoC: codecs: wcd934x: remove redundant ret variable Srinivas Kandagatla
2021-11-30 16:31 ` Mark Brown
2021-11-30 16:33 ` Srinivas Kandagatla
2021-11-30 16:37 ` Mark Brown [this message]
2021-11-30 16:05 ` [PATCH 3/4] ASoC: codecs: wcd934x: return correct value from mixer put Srinivas Kandagatla
2021-11-30 16:05 ` [PATCH 4/4] ASoC: codecs: wsa881x: fix return values from kcontrol put Srinivas Kandagatla
2021-12-01 18:32 ` [PATCH 0/4] ASoC: codecs: Qualcomm codecs fix kcontrol put return values Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaZTQVP6YMFZcSVI@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox