Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oh Eomji <eomji.oh@samsung.com>
Cc: alsa-devel@alsa-project.org,
	JaeHun Jung <jh0801.jung@samsung.com>,
	Leon Romanovsky <leon@kernel.org>,
	Pavel Skripkin <paskripkin@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 1/2] sound: usb: Add vendor's hooking interface
Date: Mon, 7 Mar 2022 08:55:18 +0100	[thread overview]
Message-ID: <YiW6ZqnINsOSyN+z@kroah.com> (raw)
In-Reply-To: <1646619720-97113-1-git-send-email-eomji.oh@samsung.com>

On Mon, Mar 07, 2022 at 11:21:59AM +0900, Oh Eomji wrote:
> In mobile, a co-processor can be used with USB audio to improve power
> consumption.  To support this type of hardware, hooks need to be added
> to the USB audio subsystem to be able to call into the hardware when
> needed.
> 
> The main operation of the call-backs are:
>   - Initialize the co-processor by transmitting data when initializing.
>   - Change the co-processor setting value through the interface
>     function.
>   - Configure sampling rate
>   - pcm open/close
>   - other housekeeping
> 
> Known issues:
>   - This only supports one set of callback hooks, meaning that this only
>     works if there is one type of USB controller in the system.  This
>     should be changed to be a per-host-controller interface instead of
>     one global set of callbacks.

Also, this is a non-starter, and not going to work at all, sorry.  Most
devices have more than one USB controller in the system, and we can
never accept changes that break that model.

Nor would you want us to, as it would break many Samsung devices...

thanks,

greg k-h

      parent reply	other threads:[~2022-03-07  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220307022409epcas2p4a2955a746c87d66564556e18ab94845f@epcas2p4.samsung.com>
2022-03-07  2:21 ` [PATCH 1/2] sound: usb: Add vendor's hooking interface Oh Eomji
2022-03-07  2:22   ` [PATCH 2/2] sound: usb: Calling vendor's call-back function within usb audio operation Oh Eomji
2022-03-07  7:54   ` [PATCH 1/2] sound: usb: Add vendor's hooking interface Greg Kroah-Hartman
2022-03-07  7:55   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiW6ZqnINsOSyN+z@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=eomji.oh@samsung.com \
    --cc=jh0801.jung@samsung.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paskripkin@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox