From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42E69C433F5 for ; Thu, 7 Apr 2022 14:29:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 942CB17D5; Thu, 7 Apr 2022 16:28:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 942CB17D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649341742; bh=rvgOuVepiat93jjbiIHz1uDoVSPTzuq6D+lseJsHMlc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZRF8t66+7rizX4kHzElZ9fqabhFVCokyD6ynKQ1ZRL9fHF+UjRlubygWiG/B4NZk1 PpgTCsMVCk03jEaXMmZEr2mozkizpksyF1oC3K6DQsJW1PAlbcl2hGAXdtOBft7kvz qz1tW2KfGTLJxZhwAxSms/+35lBtxE67FqKt4wds= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 258A3F80085; Thu, 7 Apr 2022 16:28:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 56CA2F8024C; Thu, 7 Apr 2022 16:28:07 +0200 (CEST) Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4440FF8012A; Thu, 7 Apr 2022 16:27:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4440FF8012A Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94.2) (envelope-from ) id 1ncT6r-0000NC-PG; Thu, 07 Apr 2022 16:27:41 +0200 Date: Thu, 7 Apr 2022 15:27:35 +0100 From: Daniel Golle To: Allen-KH Cheng Subject: Re: [PATCH v7 0/1] firmware: mtk: add adsp ipc protocol for SOF Message-ID: References: <20220407130338.28939-1-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407130338.28939-1-allen-kh.cheng@mediatek.com> Cc: devicetree@vger.kernel.org, Linux-ALSA , linux-kernel@vger.kernel.org, Kai Vehmanen , Liam Girdwood , cujomalainey@google.com, Kevin Hilman , Takashi Iwai , Pierre-Louis Bossart , Project_Global_Chrome_Upstream_Group@mediatek.com, tzungbi@google.com, Mark Brown , linux-mediatek@lists.infradead.org, Ranjani Sridharan , Chen-Yu Tsai , Matthias Brugger , Daniel Baluta , linux-arm-kernel@lists.infradead.org, sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Apr 07, 2022 at 09:03:37PM +0800, Allen-KH Cheng wrote: > This patch provides mediatek adsp ipc support for SOF. > ADSP IPC protocol offers (send/recv) interfaces using > mediatek-mailbox APIs. > > This patch was tested and confirmed to with SOF fw on MT8195 > cherry board. ... confirmed to **work** with ... is probably what you meant to write here. > > Based on matthias.bgg/linux.git, v5.18-next/soc > changes since v6: > - rebase to matthias.bgg/linux.git, v5.18-next/soc > - Prefer "GPL" over "GPL v2" for MODULE_LICENSE > > changes since v5: > - fix WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox > /mtk-adsp-mailbox.o. Add MODULE_LICENSE in the last line. > - Due to WARNING: Missing or malformed SPDX-License-Identifier tag > in line 1 in checkpatch, we don't remove SPDX-License in line 1. > > changes since v4: > - add error message for wrong mbox chan > > changes since v3: > - rebase on v5.16-rc8 > - update reviewers > > changes since v2: > - add out tag for two memory free phases > > changes since v1: > - add comments for mtk_adsp_ipc_send and mtk_adsp_ipc_recv > - remove useless MODULE_LICENSE > - change label name to out_free > > > Allen-KH Cheng (1): > firmware: mediatek: add adsp ipc protocol interface > > drivers/firmware/Kconfig | 1 + > drivers/firmware/Makefile | 1 + > drivers/firmware/mediatek/Kconfig | 9 + > drivers/firmware/mediatek/Makefile | 2 + > drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++ > .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ > 6 files changed, 239 insertions(+) > create mode 100644 drivers/firmware/mediatek/Kconfig > create mode 100644 drivers/firmware/mediatek/Makefile > create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c > create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h > > -- > 2.18.0 >