Re: [PATCH v1 2/2] update to support either TAS2764 or TAS2780

[Rob Herring <robh@kernel.org>]

On Fri, Apr 08, 2022 at 10:11:19PM +0800, Raphael-Xu wrote:
> update tas27xx.yaml to support either TAS2764 or TAS2780

DT patches must go to DT list. 

Now that this is in linux-next, it's breaking 'make dt_binding_check':


./Documentation/devicetree/bindings/sound/tas27xx.yaml:24:7: [error] syntax error: could not find expected ':' (syntax)
./Documentation/devicetree/bindings/sound/tas27xx.yaml:  while scanning a simple key
  in "<unicode string>", line 23, column 7
could not find expected ':'
  in "<unicode string>", line 24, column 7
make[1]: *** Deleting file 'Documentation/devicetree/bindings/sound/tas27xx.example.dts'
Traceback (most recent call last):
  File "/usr/local/bin/dt-extract-example", line 52, in <module>
    binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
    return constructor.get_single_data()
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data
    node = self.composer.get_single_node()
  File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
  File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 852, in _ruamel_yaml.CParser._compose_sequence_node
  File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 23, column 7
could not find expected ':'
  in "<unicode string>", line 24, column 7


> 
> Signed-off-by: Raphael-Xu <13691752556@139.com>
> ---
>  .../devicetree/bindings/sound/tas27xx.yaml     | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas27xx.yaml b/Documentation/devicetree/bindings/sound/tas27xx.yaml
> index 5bf8c76ecda1..191f4bceb4ee 100644
> --- a/Documentation/devicetree/bindings/sound/tas27xx.yaml
> +++ b/Documentation/devicetree/bindings/sound/tas27xx.yaml
> @@ -1,25 +1,27 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> -# Copyright (C) 2020 Texas Instruments Incorporated
> +# Copyright (C) 2020-2022 Texas Instruments Incorporated
>  %YAML 1.2
>  ---
> -$id: "http://devicetree.org/schemas/sound/tas2764.yaml#"
> +$id: "http://devicetree.org/schemas/sound/tas27xx.yaml#"

This belonged in patch 1.

>  $schema: "http://devicetree.org/meta-schemas/core.yaml#"
>  
> -title: Texas Instruments TAS2764 Smart PA
> +title: Texas Instruments TAS2764/TAS2780 Smart PA
>  
>  maintainers:
> -  - Dan Murphy <dmurphy@ti.com>
> +  - Shenghao Ding <shenghao-ding@ti.com>
>  
>  description: |
> -  The TAS2764 is a mono, digital input Class-D audio amplifier optimized for
> -  efficiently driving high peak power into small loudspeakers.
> -  Integrated speaker voltage and current sense provides for
> -  real time monitoring of loudspeaker behavior.
> +  The TAS2764/TAS2780 is a mono, digital input Class-D audio amplifier
> +  optimized for efficiently driving high peak power into small
> +  loudspeakers. Integrated speaker voltage and current sense provides
> +  for real time monitoring of loudspeaker behavior.
>  
>  properties:
>    compatible:
>      enum:
>        - ti,tas2764
> +      or
> +      - ti,tas2780

'or'  in not valid.

Please submit a fix ASAP.

Rob