From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB319C433EF for ; Fri, 22 Apr 2022 13:55:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0E26917F8; Fri, 22 Apr 2022 15:54:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0E26917F8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650635700; bh=0vRCxKznfsUI9hIjj5OVe1z6+xofAFlPjoFe7uzz/UM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CJAT12bFjmvvtsgqxksv7mmVPMCiUB5fGnS3yb4pKATet6X3+3fcK6HnADQv2jzlE wP8HnEGJI/UBU/w9r0qXoBxyTKoc2I2DnjWhhAnyJsR9Rot/vRxrN+qAEvZx09R8Aw xSd5Y5zKgodoBiZ7V1WHKgQi7+pMeZR2vPXMX39k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C567CF80C15; Fri, 22 Apr 2022 15:32:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 70A4CF80279; Thu, 21 Apr 2022 08:24:46 +0200 (CEST) Received: from muru.com (muru.com [72.249.23.125]) by alsa1.perex.cz (Postfix) with ESMTP id 40F6FF800C1 for ; Thu, 21 Apr 2022 08:24:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 40F6FF800C1 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 53E33811B; Thu, 21 Apr 2022 06:21:49 +0000 (UTC) Date: Thu, 21 Apr 2022 09:24:39 +0300 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH 40/41] [TO BE REBASED] ARM: OMAP1: clock: Convert to CCF Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-41-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133723.1394715-41-arnd@kernel.org> X-Mailman-Approved-At: Fri, 22 Apr 2022 15:31:40 +0200 Cc: Ulf Hansson , linux-usb@vger.kernel.org, Linus Walleij , linux-fbdev@vger.kernel.org, Dominik Brodowski , Lee Jones , Daniel Thompson , aaro.koskinen@iki.fi, Peter Ujfalusi , Helge Deller , jmkrzyszt@gmail.com, Russell King , Krzysztof Kozlowski , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann , Mark Brown , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Paul Walmsley , Jingoo Han , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Hilman , Vinod Koul , dmaengine@vger.kernel.org, alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * Arnd Bergmann [220419 13:39]: > From: Janusz Krzysztofik > + /* protect clk->enable_reg from concurrent access via clk_set_rate() */ > + if (clk->enable_reg == OMAP1_IO_ADDRESS(ARM_CKCTL)) > + spin_lock_irqsave(&arm_ckctl_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(ARM_IDLECT2)) > + spin_lock_irqsave(&arm_idlect2_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(MOD_CONF_CTRL_0)) > + spin_lock_irqsave(&mod_conf_ctrl_0_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(MOD_CONF_CTRL_1)) > + spin_lock_irqsave(&mod_conf_ctrl_1_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(SWD_CLK_DIV_CTRL_SEL)) > + spin_lock_irqsave(&swd_clk_div_ctrl_sel_lock, flags); > + Eventually there should be just separate clock controller instances for the clock registers banks, and then this should all disappear as the lock is instance specific. Anyways, that's probably best done as a separate changes later on. Regards, Tony