From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16ECCC433F5 for ; Wed, 27 Apr 2022 17:03:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 14EBF836; Wed, 27 Apr 2022 19:02:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 14EBF836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1651078997; bh=ouO9czTH1hGnxhRnNmCrMytCCUcGkvz2EgFW4yiQlKY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kb4nZOjYrf+33+kHxMKf3Qa9D2NcpLMsjVCVSv1YCt8qJIW1LoT3wj5mgj+Xo/xs5 E9GNl3ASK0G4+njD371TMRIdta7a/+s4LHs92sjOF9Un/LskxIQaWNAKcQJXqUhDKi 57s0djcI6OT6Nb3ClRqQYIRUj5fnp8YoZay/puzk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AB2AFF80155; Wed, 27 Apr 2022 19:02:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 738D5F8016E; Wed, 27 Apr 2022 19:02:25 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 13B5BF80152 for ; Wed, 27 Apr 2022 19:02:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 13B5BF80152 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P41MUKbW" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 80A3B61DD9; Wed, 27 Apr 2022 17:02:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E2B5C385A9; Wed, 27 Apr 2022 17:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651078936; bh=ouO9czTH1hGnxhRnNmCrMytCCUcGkvz2EgFW4yiQlKY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P41MUKbWcbp+/p4irkEFK7rEw3lVlBg/J/trLlJiHk+9o+VybeWYbjl1vWl0xJ7WF axwKtNA3sh6/iPwHybf7RG4lQ2Mk5nQGghluWK+WnMghaRhE2BtOzxFC+wKFf3P77q NzX7XfZ2XbTs3qQ4zgcFPD4D8xleg8CaH/+56UvncWtlvCa0duPXZR6mQ3Y3FPJibE AHDiKn4FWNUW9EUZyO3xK7E2ZWQe1mFJbnyjQjIymW1xzJGCaxvZBWwm9JKOL3nJ75 Inv2/YtFcIUPKR+X9V4jm1f4XW70VLmwCzKEwwiI24iCXmHh0uukq8kY/CwdUqVf84 NBAegH8Jw3AHg== Date: Wed, 27 Apr 2022 18:02:12 +0100 From: Mark Brown To: Charles Keepax Subject: Re: WM8962 crashing on suspend Message-ID: References: <20220426174150.GZ38351@ediswmail.ad.cirrus.com> <20220427145730.GE38351@ediswmail.ad.cirrus.com> <20220427164825.GH38351@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JBWjWul9bDTCdfX+" Content-Disposition: inline In-Reply-To: <20220427164825.GH38351@ediswmail.ad.cirrus.com> X-Cookie: Buckle up! Cc: ALSA Development Mailing List , patches@opensource.cirrus.com, Takashi Iwai , Liam Girdwood , Adam Ford X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --JBWjWul9bDTCdfX+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 27, 2022 at 04:48:25PM +0000, Charles Keepax wrote: > Yeah in my head snd_soc_suspend would have been called which > would (assuming the DAI doesn't have ignore_suspend set) shut > down the DAPM graph for the audio route, causing the runtime > references to all be released and the CODEC to be suspended > through runtime_pm. Not sure if I missed something there, and Runtime suspend won't do anything beyond tracking the reference count when we're in the middle of system suspend IIRC, it won't actually call the operations. > that also allows for systems where the CODEC doesn't suspend > during system suspend. That said guess there probably arn't > any use-cases for that on wm8962 and I am more than happy to > use the force_suspend ops if you are happy with it. The other option would be to move the runtime PM stuff into the bias level configuration I guess. --JBWjWul9bDTCdfX+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJpdxMACgkQJNaLcl1U h9AiLAf/V0iFrJXSvKhJSN37re/9556nmJM0hkzqFzuDHY0aNA3GXqQuxwzRwZeb WBG/TfXmzyFOSGFHu2XNzxiA3Q87nVcQIyKoEftz8th7lqC1B5ZZHd6mbN8Seydh I/zT5enwLnMzObA/cT0xlZduStCptlOfWLXcm5XNzOQrYhYZTsV8+0DcPdu5eZSw TC+zYtbPM2tNc7DKSf/JipuT595Wh1C3o5g03CDwwoybHqotObIdWz6yN1gwFB1g vIKyMP2mEOXdQGY/3F7ZoL7e8dVw4CozymEVg/7bbEo0WsGYX70JVN/84TQYGeLe 1gzgl6Az9g5MgsGOCRuA9ZHVXjDr8A== =dGQx -----END PGP SIGNATURE----- --JBWjWul9bDTCdfX+--