From: Mark Brown <broonie@kernel.org>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/3] ASoC: cs42l42: Move CS42L42 register descriptions to general include
Date: Thu, 5 May 2022 13:19:09 +0100 [thread overview]
Message-ID: <YnPAvXKWtQsF2PG9@sirena.org.uk> (raw)
In-Reply-To: <20220504161236.2490532-2-sbinding@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
On Wed, May 04, 2022 at 05:12:34PM +0100, Stefan Binding wrote:
> This is to allow the hda driver to have access to the register names,
> for improved maintainability.
> Also ensure new header is aligned to 100 columns.
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
> include/sound/cs42l42.h | 810 ++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/cs42l42.h | 826 +------------------------------------
> 2 files changed, 812 insertions(+), 824 deletions(-)
> create mode 100644 include/sound/cs42l42.h
You should use git format-patch -M for things like this, it makes the
diff more legible though in this case the fact that you've mixed content
changes in with the rename will not help - those are separate changes
and it's hard to verify things as they are. Still, seems to be OK
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-05 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 16:12 [PATCH v1 0/3] Add Manual Mode Jack Detection for CS42L42 in HDA Stefan Binding
2022-05-04 16:12 ` [PATCH v1 1/3] ASoC: cs42l42: Move CS42L42 register descriptions to general include Stefan Binding
2022-05-05 12:19 ` Mark Brown [this message]
2022-05-04 16:12 ` [PATCH v1 2/3] ALSA: hda/cs8409: Use general cs42l42 include in cs8409 hda driver Stefan Binding
2022-05-04 16:12 ` [PATCH v1 3/3] ALSA: hda/cs8409: Support manual mode detection for CS42L42 Stefan Binding
2022-05-05 3:59 ` Chris Chiu
2022-05-09 8:47 ` [PATCH v1 0/3] Add Manual Mode Jack Detection for CS42L42 in HDA Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnPAvXKWtQsF2PG9@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox