From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A11AC433EF for ; Thu, 5 May 2022 22:36:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10E231825; Fri, 6 May 2022 00:35:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10E231825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1651790181; bh=fIcmMOB4OTzUhPRJw5zxd1he8Ws9Ea91j5a5noC1OwA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=okWnvPRMlQr42UmjqtEilFPzSZ7f+9EwgABIcUeN9mt2nw9rVmYf3LVhim8UTzyWj KrCu0WV0gTAxFubMSB05g/kDNzcQD4VvG9zxJ52SyA2ktNmli2AM12R74hMnWwXdZ7 nHfOl6ON/4AEBTFoSR5m956ehAou+D8nDayhC+aw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 53F32F804B3; Fri, 6 May 2022 00:34:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D02B0F800D3; Fri, 6 May 2022 00:34:55 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 24252F800D3 for ; Fri, 6 May 2022 00:34:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 24252F800D3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dDjiqn3i" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CB3761F50; Thu, 5 May 2022 22:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA4FAC385A4; Thu, 5 May 2022 22:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651790084; bh=fIcmMOB4OTzUhPRJw5zxd1he8Ws9Ea91j5a5noC1OwA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dDjiqn3iXIxsl95pJLRm9hrJchx4WfXEocyDn8SVGogcQ5ZgMmKnU384LgZ4FZvGP cjgJqRC9zMQbrvZDuSbZJQboS77aP9g4SNbH88A0AC0dxpNfh0xc6f9SX6tp/JwV94 q2boySmrpnWmzzZqy8AB0OIdh4Qd7DbjWk6tC+fI= Date: Thu, 5 May 2022 23:10:43 +0200 From: Greg Kroah-Hartman To: Tinghan Shen Subject: Re: [RESEND PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface Message-ID: References: <20220505053048.13804-1-tinghan.shen@mediatek.com> <20220505053048.13804-2-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505053048.13804-2-tinghan.shen@mediatek.com> Cc: alsa-devel@alsa-project.org, Allen-KH Cheng , Daniel Vetter , Javier Martinez Canillas , Pierre-Louis Bossart , Project_Global_Chrome_Upstream_Group@mediatek.com, Tzung-Bi Shih , Cristian Marussi , Michal Suchanek , Arnd Bergmann , Sudeep Holla , Simon Trimmer , Mark Brown , John Stultz , Matthias Brugger , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Borislav Petkov , linux-kernel@vger.kernel.org, Thomas Zimmermann , YC Hung , linux-mediatek@lists.infradead.org, Curtis Malainey , Etienne Carriere X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, May 05, 2022 at 01:30:48PM +0800, Tinghan Shen wrote: > From: TingHan Shen > > Some of mediatek processors contain > the Tensilica HiFix DSP for audio processing. > > The communication between Host CPU and DSP firmware is > taking place using a shared memory area for message passing. > > ADSP IPC protocol offers (send/recv) interfaces using > mediatek-mailbox APIs. > > We use two mbox channels to implement a request-reply protocol. > > Signed-off-by: Allen-KH Cheng > Signed-off-by: TingHan Shen > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Curtis Malainey > Reviewed-by: Tzung-Bi Shih > Reviewed-by: YC Hung > Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/firmware/Kconfig | 1 + > drivers/firmware/Makefile | 1 + > drivers/firmware/mediatek/Kconfig | 9 + > drivers/firmware/mediatek/Makefile | 2 + > drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++ > .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ > 6 files changed, 239 insertions(+) > create mode 100644 drivers/firmware/mediatek/Kconfig > create mode 100644 drivers/firmware/mediatek/Makefile > create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c > create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h Why do you have a .h file, and export symbols in your .c file, yet you have no user of these symbols or header file? Without a user, we can not take this, sorry. This should just be one single .c file. Also, why a whole subdirectory for just one .c file? thanks, greg k-h