Re: [PATCH 02/14] ASoC: codecs: Add HD-Audio codec driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

On Wed, Apr 27, 2022 at 10:47:12AM -0500, Pierre-Louis Bossart wrote:
> On 4/27/22 03:18, Cezary Rojewski wrote:

> > Add generic ASoC equivalent of ALSA HD-Audio codec. This codec is
> > designed to follow HDA_DEV_LEGACY convention. Driver wrapps existing
> > hda_codec.c handlers to prevent code duplication within the newly added

> I am surprised the explanations don't even mention the existence of hdac_hda.c

> I thought the series was about adding machine drivers, but this
> also adds code on the sound/soc/codecs/ side which I didn't see
> coming.

> I am not qualified to review this part of the code, I just
> wonder about duplication of functionality.

> At the very least an explanation on why you decided to NOT use
> hdac_hda.c would be useful to reviewers and maintainers.

Right, why the duplication here?  Can't we fix or extend the
existing code to do whatever it's not currently doing which
compels reimplementation?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]