From: Mark Brown <broonie@kernel.org>
To: Olivier MOYSAN <olivier.moysan@foss.st.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
alexandre.torgue@foss.st.com, linux-kernel@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>,
tiwai@suse.com, mcoquelin.stm32@gmail.com,
arnaud.pouliquen@foss.st.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: stm32: sai: Use of_device_get_match_data() to simplify code
Date: Mon, 23 May 2022 19:57:05 +0100 [thread overview]
Message-ID: <YovZAf4S0XphBsco@sirena.org.uk> (raw)
In-Reply-To: <69d5cef3-57c0-9bc7-a83b-a85ef1c4cf29@foss.st.com>
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Mon, May 23, 2022 at 03:28:48PM +0200, Olivier MOYSAN wrote:
> The current patch requires a change in the driver.
> Either changing STM_SAI_x_ID enums, or replacing data by a struct.
> For instance:
> struct stm32_sai_comp_data {
> unsigned int id;
> }
> struct stm32_sai_comp_data stm32_sai_comp_data_a = {
> .id = STM_SAI_A_ID;
> }
> struct of_device_id stm32_sai_sub_ids[] = {
> .data = &stm32_sai_comp_data_a},
> }
Either approach works for me (or a revert for that matter).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-23 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 12:42 [PATCH] ASoC: stm32: sai: Use of_device_get_match_data() to simplify code Tang Bin
2022-05-23 13:28 ` Olivier MOYSAN
2022-05-23 18:57 ` Mark Brown [this message]
2022-05-24 1:44 ` [PATCH] ASoC: stm32: sai: Use of_device_get_match_data() tosimplify code tangbin
2022-05-24 14:30 ` Olivier MOYSAN
2022-05-25 7:36 ` [PATCH] ASoC: stm32: sai: Use of_device_get_match_data()tosimplify code tangbin
2022-05-25 12:30 ` Olivier MOYSAN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YovZAf4S0XphBsco@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@foss.st.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox