From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0AEAC433EF for ; Thu, 9 Jun 2022 14:18:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E46931B2C; Thu, 9 Jun 2022 16:17:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E46931B2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1654784322; bh=sX8Pt/a3TTJmaI7w+Ef/bE8wur8yI9TLQ06dLxubKFk=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GIOdXojp+Ft5V++Vjy2UB5nhV2vuCVFeGEd6clgTVFmFlEfIVKTrIXsCt1gF+wQo+ Al8EKC0eNP5qVCY3tEEJRoMrAVfKoHEBf3+qBlX2S0WlRZc2GUo8ejIh2kcBtY2HJ3 SoN33NQPPyW7tmTng9MKEdN9Ab9CjGTpyek/J3aU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3B167F8012F; Thu, 9 Jun 2022 16:17:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5FED0F8019D; Thu, 9 Jun 2022 16:17:50 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0AD5BF80116 for ; Thu, 9 Jun 2022 16:17:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0AD5BF80116 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d7ccdiR0" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE26C61DC5; Thu, 9 Jun 2022 14:17:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81E27C34115; Thu, 9 Jun 2022 14:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654784265; bh=sX8Pt/a3TTJmaI7w+Ef/bE8wur8yI9TLQ06dLxubKFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d7ccdiR0u2LRgFgjyc9iVdg0xOyhNTdNN4sG8GsUL/cLW4kveyXXPTdzaD4qmQz5Q cpGdFqdHx1NUKv0mOesXEt4iiEtTcTHn7+ehv/qHRc/LztHnwTAnvtJDJj7B3obbyN C3NeEaRfWR01D4yx5SFF+df87K/jz+IkqF3I9WQNZAQopyoOFLfcqVigen5BDhZbk0 5FV1HNInrYPAN/4lr+H6S2VMqVI1lW2rz948TwBaOZbo8wkRIG1c2Txd/yjuW2lOYH JdjnFH4xyT08H1iO8L14zxptf3kFkdULfI9OE83sHrTmojaGgxET4sW/DY/TDowQZg b6HQkbOMRhBVw== Date: Thu, 9 Jun 2022 15:17:40 +0100 From: Mark Brown To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Subject: Re: [PATCH 04/11] ASoC: codecs: rt274: Move irq registration and cleanup Message-ID: References: <20220609133541.3984886-1-amadeuszx.slawinski@linux.intel.com> <20220609133541.3984886-5-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ooVO84OvLexuBgxN" Content-Disposition: inline In-Reply-To: <20220609133541.3984886-5-amadeuszx.slawinski@linux.intel.com> X-Cookie: Space is limited. Cc: Oder Chiou , Pierre-Louis Bossart , Cezary Rojewski , alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --ooVO84OvLexuBgxN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 09, 2022 at 03:35:34PM +0200, Amadeusz S=C5=82awi=C5=84ski wrot= e: > Currently irq is registered when i2c driver is loaded, it is unnecessary > when component is unused. Initialize irq only when we probe ASoC > component. No, this makes things worse - we should acquire resources in the device level probe so that we handle deferred probe more gracefully, triggering a defer from the device trying to acquire the resource makes it clearer what's going on and reduces the amount of work we do on deferred probe attempts. Having an interrupt registered has no meaningful cost. --ooVO84OvLexuBgxN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKiAQMACgkQJNaLcl1U h9DuhAf+J1PgentaTUp6mPl8bQKR8HlSxKPej1icR/nsri8KOYcfAbxJjbRnQm0m hVKjqEz5Rkvm9Q844ffxyOV1x7iBYOIpPmj0G5FJkcs4nr6n2UICRB9zjXB8n+Vw 3np4LQdu5xmR+j8onv2fCFHWA8h9JJlUSNPBYmRzZtKeyiKaQvMNKuHzwRJWsf/r HroIXWuko0EjLj7Uxs7R3JxwNstLeyxN9Gr37oA8Y7mYTGfSz/0zC96rsr1y0Qr4 qhcCn8fFnfykBldlFEunh9F9XVW2RbPQzxmkSVsJWd57xQoubWUlh/S9xjvXRSPi /PKnsOVjCi0vTfACt7EjxpcezNPiKw== =Dhmy -----END PGP SIGNATURE----- --ooVO84OvLexuBgxN--