From: Mark Brown <broonie@kernel.org>
To: Pierluigi Passaro <pierluigi.p@variscite.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"nicoleotsuka@gmail.com" <nicoleotsuka@gmail.com>,
"Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"shengjiu.wang@gmail.com" <shengjiu.wang@gmail.com>,
"tiwai@suse.com" <tiwai@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Eran Matityahu <eran.m@variscite.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Alifer Willians de Moraes <alifer.m@variscite.com>,
"patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
"festevam@gmail.com" <festevam@gmail.com>
Subject: Re: [PATCH 4/4] ASoC: wm8904: add DMIC support
Date: Tue, 21 Jun 2022 14:11:35 +0100 [thread overview]
Message-ID: <YrHDh6lzdZXj7HcQ@sirena.org.uk> (raw)
In-Reply-To: <AM6PR08MB4376411B180D8860E2AD3AE0FFB09@AM6PR08MB4376.eurprd08.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
On Mon, Jun 20, 2022 at 07:53:56PM +0000, Pierluigi Passaro wrote:
> > This means that DMICDAT2 is not usefully selectable at runtime, you've
> > got IN1 as digital and IN2 as analogue, so while the DMIC/ADC switch is
> > useful the DMIC1/2 switch is not.
> A customer could have the following working configuration
> - pin 1: DMIC_CLK
> - pin 24: LINEIN2R
> - pin 25: DMICDAT2
> - pin 26: LINEIN2L
> - pin 27: DMICDAT1
> with no shared pins: here there's the chance to select DMIC1, DMIC2 and
> LINEIN2 at runtime: I can't find a reason for a fixed behavior.
> Can you please elaborate ?
So in that case the driver should offer the DMIC1/2 selection. The
driver should be looking at which pins are wired up as DMICs and only
registering controls that can actually be used in the system based on
the pins that are wired up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-21 13:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 14:10 [PATCH 1/4] ASoC: fsl-asoc-card: add WM8904 support Alifer Moraes
2022-03-07 14:10 ` [PATCH 2/4] ASoC: bindings: fsl-asoc-card: Add compatible string for wm8904 Alifer Moraes
2022-03-07 14:10 ` [PATCH 3/4] ASoC: wm8904: extend device tree support Alifer Moraes
2022-03-07 16:16 ` Mark Brown
2022-03-10 20:51 ` Rob Herring
2022-06-20 14:39 ` Pierluigi Passaro
2022-03-07 14:10 ` [PATCH 4/4] ASoC: wm8904: add DMIC support Alifer Moraes
2022-03-07 16:25 ` Mark Brown
2022-06-20 19:53 ` Pierluigi Passaro
2022-06-21 13:11 ` Mark Brown [this message]
2022-03-11 17:16 ` [PATCH 1/4] ASoC: fsl-asoc-card: add WM8904 support Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2022-06-20 14:49 [PATCH 4/4] ASoC: wm8904: add DMIC support Pierluigi Passaro
2022-06-20 14:56 ` Mark Brown
2022-06-20 15:03 Pierluigi Passaro
2022-06-20 15:09 ` Mark Brown
2022-06-20 15:30 Pierluigi Passaro
2022-06-20 17:38 ` Mark Brown
2022-06-20 17:52 Pierluigi Passaro
2022-06-20 18:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrHDh6lzdZXj7HcQ@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alifer.m@variscite.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=eran.m@variscite.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=pierluigi.p@variscite.com \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox