From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2587BC43334 for ; Thu, 23 Jun 2022 12:42:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B2DB01DE2; Thu, 23 Jun 2022 14:41:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B2DB01DE2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655988152; bh=VEKQqqv0GJJfssR5O+DbzVMdKUZxwolWDybsziOqZNo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ax3iNmCu8wrXKGOLflgOH+ibEfnubCJXXs4y1HqfSBOLaToulvn0+ZQhJWoqEnmtw ZtBORRIc4/AFgZbx1CGTVQLf/B7nHMRoQR1+NazDg0QmgxCX4mYwrvwd5LgrGz5umj C9aQDXXqKMH/DpuklVUc++5y/yS6ciZacXPbD/dU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 501EAF800D0; Thu, 23 Jun 2022 14:41:42 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 27D97F800BD; Thu, 23 Jun 2022 14:41:41 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27329F800BD for ; Thu, 23 Jun 2022 14:41:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27329F800BD Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mP4e/YxZ" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 08D8161C52; Thu, 23 Jun 2022 12:41:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC524C3411B; Thu, 23 Jun 2022 12:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655988091; bh=VEKQqqv0GJJfssR5O+DbzVMdKUZxwolWDybsziOqZNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mP4e/YxZ8SvnRHgTYBotpx2q2gyxVmuP+Dj7EWGigubb6+JnPDxEUSwo4E7BK3lZo PPrzQlZ3R3kE+AWDrE+4ZzxOBWWqMqBEact1Pe21v5Kpj6hfICQSn4hK+CWKat3Zr3 4xndA33E9xINreJ8aMNJamSjLFSPHEwJiGhpBYipFfIyJtqatN1jcbyl4mEj69QsOd Z/CvQWEZ1gpQF+B+YLMkYPS49aj5cnaVJ4aKeLjdEpOTKLsjE3CrXtVJ139RFmYGsb TaRkoyVZ3EN3AMgH41R/CxZrnMbHBJvSNh7g+WoHEyKXZCVxB2LSx2QknwEjQNVvY8 PV2nSHSQblf5w== Date: Thu, 23 Jun 2022 18:11:27 +0530 From: Vinod Koul To: "Rafael J. Wysocki" Subject: Re: [PATCH v2 14/16] soundwire: Use acpi_dev_for_each_child() Message-ID: References: <1843211.tdWV9SEqCh@kreacher> <2653857.mvXUDI8C0e@kreacher> <9017824.rMLUfLXkoz@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Hans de Goede , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Linux PM , Bard Liao , "Rafael J. Wysocki" , LKML , Pierre-Louis Bossart , Linux ACPI , Sakari Ailus , Sanyog Kale , Andy Shevchenko , Mika Westerberg X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 23-06-22, 14:29, Rafael J. Wysocki wrote: > On Thu, Jun 23, 2022 at 10:10 AM Vinod Koul wrote: > > > > On 13-06-22, 20:35, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Instead of walking the list of children of an ACPI device directly, > > > use acpi_dev_for_each_child() to carry out an action for all of > > > the given ACPI device's children. > > > > > > This will help to eliminate the children list head from struct > > > acpi_device as it is redundant and it is used in questionable ways > > > in some places (in particular, locking is needed for walking the > > > list pointed to it safely, but it is often missing). > > > > Applied, thanks > > Thanks, but the export of acpi_dev_for_each_child() is being added by > one of the previous patches in the series, so this one will not > compile without the rest of the series in the modular case. Aha, I checked the symbol exists and my test build passed! > > Is this not a problem? Yes indeed, so can you give a tag for that and or would you like to taje this thru ACPI tree, in that case Acked-By: Vinod Koul BR -- ~Vinod