Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vsujithkumar.Reddy@amd.com
Cc: alsa-devel@alsa-project.org
Subject: [bug report] ASoC: amd: acp: ACP code generic to support newer platforms
Date: Wed, 13 Jul 2022 14:37:43 +0300	[thread overview]
Message-ID: <Ys6uh4k7rl0qPNZp@kili> (raw)

Hello V sujith kumar Reddy,

This is a semi-automatic email about new static checker warnings.

The patch b24484c18b10: "ASoC: amd: acp: ACP code generic to support 
newer platforms" from Jul 7, 2022, leads to the following Smatch 
complaint:

    sound/soc/amd/acp/acp-platform.c:99 i2s_irq_handler()
    warn: variable dereferenced before check 'adata' (see line 94)

sound/soc/amd/acp/acp-platform.c
    93		struct acp_dev_data *adata = data;
    94		struct acp_resource *rsrc = adata->rsrc;
                                            ^^^^^^^^^^^
The patch adds a new dereference

    95		struct acp_stream *stream;
    96		u16 i2s_flag = 0;
    97		u32 val, val1, i;
    98	
    99		if (!adata)
                    ^^^^^^
The old code assumed that "adata" could be NULL but hopefully that
check can be removed?

   100			return IRQ_NONE;
   101	

regards,
dan carpenter

                 reply	other threads:[~2022-07-13 11:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ys6uh4k7rl0qPNZp@kili \
    --to=dan.carpenter@oracle.com \
    --cc=Vsujithkumar.Reddy@amd.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox