From: Mark Brown <broonie@kernel.org>
To: Wallace Lin <savagecin@gmail.com>
Cc: alsa-devel@alsa-project.org, scott6986@gmail.com,
WTLI@nuvoton.com, SJLIN0@nuvoton.com, KCHSU0@nuvoton.com,
lgirdwood@gmail.com, YHCHuang@nuvoton.com, CTLIN0@nuvoton.com,
dardar923@gmail.com, supercraig0719@gmail.com
Subject: Re: [PATCH] ASoC: nau8821: add new widget to control system clock
Date: Fri, 8 Jul 2022 19:12:53 +0100 [thread overview]
Message-ID: <YshzpRewYS0f/3qy@sirena.org.uk> (raw)
In-Reply-To: <20220707080751.76892-1-savagecin0@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
On Thu, Jul 07, 2022 at 04:07:51PM +0800, Wallace Lin wrote:
> @@ -1430,6 +1460,7 @@ static const struct snd_soc_component_driver nau8821_component_driver = {
> .dapm_routes = nau8821_dapm_routes,
> .num_dapm_routes = ARRAY_SIZE(nau8821_dapm_routes),
> .suspend_bias_off = 1,
> + .non_legacy_dai_naming = 1,
> .idle_bias_on = 1,
> .use_pmdown_time = 1,
> .endianness = 1,
This isn't obviously connected with the rest of your change and breaks
the build since this flag has been removed in current code. It should
probably just be dropped here.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-08 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 8:07 [PATCH] ASOC: add new widget to control system clock Wallace Lin
2022-07-08 18:12 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-19 8:40 [PATCH] ASOC: nau8821: " Wallace Lin
2022-07-19 17:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YshzpRewYS0f/3qy@sirena.org.uk \
--to=broonie@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=SJLIN0@nuvoton.com \
--cc=WTLI@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=dardar923@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=savagecin@gmail.com \
--cc=scott6986@gmail.com \
--cc=supercraig0719@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox