From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 350FBC433EF for ; Thu, 14 Jul 2022 16:36:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4EC6C17BC; Thu, 14 Jul 2022 18:35:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4EC6C17BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657816580; bh=Oeo+GKMu/WggQnivksBgQ5Xh/S5r57Rq5U2RGWGI5T4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PWqWb1a4O5RMbp6J7UIOkQMiuO9fGR2b2CHGS8U7qUfuyVVkkfnWt7NIweDwcXZF6 Fum+bFAEhplifOVuM479XAsbYkzSWymWFWbq+SfvhEadgpo2kW8NckwpdeRUCP/mF1 V/L7kgb7H38RE3UR6tefeZ0G+YHbhpjvJ3n52MXo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 541FBF80542; Thu, 14 Jul 2022 18:34:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F0616F80163; Mon, 11 Jul 2022 16:35:45 +0200 (CEST) Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by alsa1.perex.cz (Postfix) with ESMTP id 21712F800E1 for ; Mon, 11 Jul 2022 16:35:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 21712F800E1 Date: Mon, 11 Jul 2022 16:35:39 +0200 From: Pablo Neira Ayuso To: Bill Wendling Subject: Re: [PATCH 12/12] netfilter: conntrack: use correct format characters Message-ID: References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-13-morbo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220609221702.347522-13-morbo@google.com> X-Mailman-Approved-At: Thu, 14 Jul 2022 18:34:36 +0200 Cc: alsa-devel@alsa-project.org, x86@kernel.org, Nick Desaulniers , Dave Hansen , Phillip Potter , linux-mm@kvack.org, Eric Dumazet , netdev@vger.kernel.org, "H. Peter Anvin" , isanbard@gmail.com, Daniel Kiper , "Rafael J. Wysocki" , Jozsef Kadlecsik , linux-acpi@vger.kernel.org, Ingo Molnar , Tom Rix , Jakub Kicinski , Paolo Abeni , llvm@lists.linux.dev, coreteam@netfilter.org, Arnd Bergmann , Ross Philipson , Nathan Chancellor , Borislav Petkov , Thomas Gleixner , linux-edac@vger.kernel.org, Tony Luck , Greg Kroah-Hartman , Florian Westphal , Takashi Iwai , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, Jan Kara , Andrew Morton , "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jun 09, 2022 at 10:16:31PM +0000, Bill Wendling wrote: > From: Bill Wendling > > When compiling with -Wformat, clang emits the following warnings: > > net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > request_module(mod_name); > ^~~~~~~~ > > Use a string literal for the format string. Applied this patch to nf-next, thanks