From: Mark Brown <broonie@kernel.org>
To: Zhu Ning <zhuning0077@gmail.com>
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, pierre-louis.bossart@linux.intel.com,
tiwai@suse.com, Zhu Ning <zhuning@everest-semi.com>,
David Yang <yangxiaohua@everest-semi.com>
Subject: Re: [PATCH v4 1/2] ASoC: codecs: add support for ES8326
Date: Fri, 29 Jul 2022 14:35:28 +0100 [thread overview]
Message-ID: <YuPiIHvkK4pb6Mae@sirena.org.uk> (raw)
In-Reply-To: <20220729090857.579785-1-zhuning0077@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Fri, Jul 29, 2022 at 05:08:56PM +0800, Zhu Ning wrote:
> +static unsigned int es8326_rates[] = {
> + 8000, 12000, 16000, 32000, 48000, 96000
> +};
> +
> +static struct snd_pcm_hw_constraint_list es8326_constraints = {
> + .count = ARRAY_SIZE(es8326_rates),
> + .list = es8326_rates,
> +};
> +
These now aren't used, you should see warnings about this which will
turn into build failures in an allmodconfig since it's built with
-Werror. Otherwise than that one small thing this now looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-29 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 9:08 [PATCH v4 1/2] ASoC: codecs: add support for ES8326 Zhu Ning
2022-07-29 9:08 ` [PATCH v4 2/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC Zhu Ning
2022-07-29 13:38 ` Rob Herring
2022-07-29 13:35 ` Mark Brown [this message]
2022-07-30 0:20 ` [PATCH v4 1/2] ASoC: codecs: add support for ES8326 kernel test robot
2022-07-30 5:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuPiIHvkK4pb6Mae@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
--cc=zhuning0077@gmail.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox