From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A2D2C00144 for ; Fri, 29 Jul 2022 14:20:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 99CEA15E0; Fri, 29 Jul 2022 16:20:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 99CEA15E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1659104451; bh=rG+qA9pRCh2XHrx6FPAQMmQX+gy1CarW8WVq6ER5xt0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i8mtz445IUOxSaIPqhzKlv3FN9+r7SFrzpM/4hRzBn6Q1HyIOwxn1pMYNq0A+7rp/ 8mayfuDaV8/OoZme1PVcrxVR8y39u43HbeK3ZWzSNf/UsEg0aKC9zjqcZhm6BF+3/C AFGQ2RNwANX0ChTsGBF3OZSYsKNtJ2z3wbzXQUAA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2E946F80430; Fri, 29 Jul 2022 16:20:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0AD47F8049C; Fri, 29 Jul 2022 16:20:00 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C01E7F800BD for ; Fri, 29 Jul 2022 16:19:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C01E7F800BD Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pv0PQedt" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5342B82803; Fri, 29 Jul 2022 14:19:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E66E1C433D6; Fri, 29 Jul 2022 14:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659104395; bh=rG+qA9pRCh2XHrx6FPAQMmQX+gy1CarW8WVq6ER5xt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pv0PQedtK+W5XN5LIhRHRvE3N86IVP8C3RjR+hcaZcAG9IFPIIpYWLmEU1hT66tjg iV29/MuQi5uAgiI1LHVsfkSw3jzhIBG+sGVT2VnWiBwQlTFViZMmBVR4LivjK2whK6 4pMAV+y3jG8AYKg3xRlbf7RwL2Vau3QV1ke0Cn1A= Date: Fri, 29 Jul 2022 16:19:52 +0200 From: Greg Kroah-Hartman To: Pierre-Louis Bossart Subject: Re: [PATCH 3/5] soundwire: sysfs: have the driver core handle the creation of the device groups Message-ID: References: <20220729135041.2285908-1-gregkh@linuxfoundation.org> <20220729135041.2285908-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Vinod Koul , alsa-devel@alsa-project.org, Bard Liao , linux-kernel@vger.kernel.org, Sanyog Kale X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jul 29, 2022 at 09:12:17AM -0500, Pierre-Louis Bossart wrote: > > > diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > > index 893296f3fe39..81c77e6ddbad 100644 > > --- a/drivers/soundwire/bus_type.c > > +++ b/drivers/soundwire/bus_type.c > > @@ -193,6 +193,7 @@ int __sdw_register_driver(struct sdw_driver *drv, struct module *owner) > > > > drv->driver.owner = owner; > > drv->driver.probe = sdw_drv_probe; > > + drv->driver.dev_groups = sdw_attr_groups; > > > > if (drv->remove) > > drv->driver.remove = sdw_drv_remove; > > Minor rebase issue: this version of the bus_type.c code is no longer > up-to-date, this patch creates a conflict with "soundwire: bus_type: fix > remove and shutdown support" merged by Vinod - should be in your > char-misc tree as well for 5.20. Sorry, did this against Linus's tree, I will rebase it against 5.20-rc1 when that comes out and resend it then. thanks, greg k-h