From: Mark Brown <broonie@kernel.org>
To: Chunxu Li <chunxu.li@mediatek.com>
Cc: alsa-devel@alsa-project.org, peter.ujfalusi@linux.intel.com,
tinghan.shen@mediatek.com, pierre-louis.bossart@linux.intel.com,
lgirdwood@gmail.com,
project_global_chrome_upstream_group@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, yc.hung@mediatek.com,
matthias.bgg@gmail.com, sound-open-firmware@alsa-project.org,
daniel.baluta@nxp.com, linux-kernel@vger.kernel.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select
Date: Thu, 4 Aug 2022 14:17:21 +0100 [thread overview]
Message-ID: <YuvG4drwG/rYoozp@sirena.org.uk> (raw)
In-Reply-To: <20220804091359.31449-2-chunxu.li@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On Thu, Aug 04, 2022 at 05:13:58PM +0800, Chunxu Li wrote:
> @@ -284,6 +284,7 @@ struct snd_sof_dsp_ops {
> void (*machine_unregister)(struct snd_sof_dev *sdev,
> void *pdata); /* optional */
> struct snd_soc_acpi_mach * (*machine_select)(struct snd_sof_dev *sdev); /*
> optional */
> + struct snd_sof_of_mach * (*of_machine_select)(struct snd_sof_dev *sdev);
I don't understand why we pass this in as a function when as far as I
can see it should always be the standard operation provided by the core
- why not just always call the function? We can tell at runtime if the
system is using DT so there's no issue there and there shouldn't be any
concerns with ACPI or other firmware interfaces.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-04 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:13 [PATCH 0/2] ASoC: SOF: Introduce of_machine_select Chunxu Li
2022-08-04 9:13 ` [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select Chunxu Li
2022-08-04 13:17 ` Mark Brown [this message]
2022-08-04 14:36 ` chunxu.li
2022-08-04 14:59 ` Mark Brown
2022-08-04 9:13 ` [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186 Chunxu Li
2022-08-04 12:41 ` Mark Brown
2022-08-04 13:21 ` chunxu.li
2022-08-04 13:33 ` Mark Brown
2022-08-04 14:47 ` chunxu.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuvG4drwG/rYoozp@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunxu.li@mediatek.com \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=project_global_chrome_upstream_group@mediatek.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tinghan.shen@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox