From: Geraldo Nascimento <geraldogabriel@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sugar Zhang <sugar.zhang@rock-chips.com>,
ALSA-devel <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH] drm/bridge: dw-hdmi-i2s: set insert_pcuv bit if hardware supports it
Date: Mon, 22 Aug 2022 11:35:46 -0300 [thread overview]
Message-ID: <YwOUQoWiPi17zvYD@geday> (raw)
In-Reply-To: <YwOEPpO0gux+njQe@sirena.org.uk>
On Mon, Aug 22, 2022 at 02:27:26PM +0100, Mark Brown wrote:
> On Sat, Aug 20, 2022 at 09:36:53PM -0300, Geraldo Nascimento wrote:
>
> > + /*
> > + * dw-hdmi introduced insert_pcuv bit in version 2.10a.
> > + * When set (1'b1), this bit enables the insertion of the PCUV
> > + * (Parity, Channel Status, User bit and Validity) bits on the
> > + * incoming audio stream (support limited to Linear PCM audio)
> > + */
> > +
> > + if (hdmi_read(audio, HDMI_DESIGN_ID) >= 0x21)
> > + conf2 |= HDMI_AUD_CONF2_INSERT_PCUV;
>
> So what if we're not handlign linear PCM?
Good question, Mark. For HBR and NL-PCM there are different bits that
need to be set in aud_conf2 Sample Register, and then insert_pcuv bit
needs to be dropped.
I don't have a sink handy however to test the other modes. Do you have
a suggestion on how to make this the default for L-PCM specifically?
Thanks,
Geraldo Nascimento
next parent reply other threads:[~2022-08-22 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YwF+JYR5DxLBnE8F@geday>
[not found] ` <YwOEPpO0gux+njQe@sirena.org.uk>
2022-08-22 14:35 ` Geraldo Nascimento [this message]
2022-08-23 14:46 ` [PATCH] drm/bridge: dw-hdmi-i2s: set insert_pcuv bit if hardware supports it Geraldo Nascimento
2022-08-23 16:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwOUQoWiPi17zvYD@geday \
--to=geraldogabriel@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=sugar.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox