From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: amit.pundir@linaro.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] soundwire: qcom: remove duplicate reset control get
Date: Tue, 23 Aug 2022 21:28:00 +0530 [thread overview]
Message-ID: <YwT5COjQAvFUB+LA@matsya> (raw)
In-Reply-To: <20220814123800.31200-1-srinivas.kandagatla@linaro.org>
On 14-08-22, 13:38, Srinivas Kandagatla wrote:
> Looks like adding clock gate flag patch forgot to remove the old code that
> gets reset control.
>
> This causes below crash on platforms that do not need reset.
>
> [ 15.653501] reset_control_reset+0x124/0x170
> [ 15.653508] qcom_swrm_init+0x50/0x1a0
> [ 15.653514] qcom_swrm_probe+0x320/0x668
> [ 15.653519] platform_probe+0x68/0xe0
> [ 15.653529] really_probe+0xbc/0x2a8
> [ 15.653535] __driver_probe_device+0x7c/0xe8
> [ 15.653541] driver_probe_device+0x40/0x110
> [ 15.653547] __device_attach_driver+0x98/0xd0
> [ 15.653553] bus_for_each_drv+0x68/0xd0
> [ 15.653559] __device_attach+0xf4/0x188
> [ 15.653565] device_initial_probe+0x14/0x20
>
> Fix this by removing old code.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-08-23 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 12:38 [PATCH] soundwire: qcom: remove duplicate reset control get Srinivas Kandagatla
2022-08-15 11:28 ` Amit Pundir
2022-08-23 15:58 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwT5COjQAvFUB+LA@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=amit.pundir@linaro.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox