From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0000C0219E for ; Mon, 17 Feb 2025 10:07:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0238760271; Mon, 17 Feb 2025 11:06:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0238760271 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1739786827; bh=RjFj+btLOrA1I0c/0XDEPot6dd9rNyckywxmgkJzq3o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TP8VDw5ZYG0P5MSiVqTHGj2Pkn5niJGsEze1kAm0caAuS4PTON2xPalSWRRlSz/4K YphQKIwlNBOGie0A89XxZ6Pw042/brYoFhtE+HX8AX3UKMpQhOv6N0OCro33wyxGnT +opEfdwD84y3UW3e4j6mIudazVRp70FaATs7ErHY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id BEC3EF80246; Mon, 17 Feb 2025 11:06:37 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4C9F1F805C4; Mon, 17 Feb 2025 11:06:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F3174F802DB; Mon, 27 Jan 2025 14:25:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 121D0F800E3 for ; Mon, 27 Jan 2025 14:25:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 121D0F800E3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ZKYB+kUr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737984335; x=1769520335; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RjFj+btLOrA1I0c/0XDEPot6dd9rNyckywxmgkJzq3o=; b=ZKYB+kUrH0p6/ErD9ZFwrU0/8Xsj0glFRvowOWqseD9gP5mnq2u+MIaF gvcjPSle550L917ZznDh0v6rvdFZiIOqcFyxcMY3p93z2y/vaOF1Tj0g5 sMr5sii3hI+poZv58Fwtm51X/LGgmwg9FLqg4gx/3HxvGHulV0VYoDpN8 hGWOxUtWKBIRTlnHcj4VbNnzPvsUAaZgNFXrmSmCHCjBuEDsszn22oNDY KJdMNo/FslU1tJr/CEtGiY0tv0vS/b/oOfd51BbyLjx+jqRLrtM8r7Ffk iUG2tpWVH5EFKgOAhZCDlaSICs5QXYH8C2jVPtfBGwAleFs6JtuiJDi8a A==; X-CSE-ConnectionGUID: ooegN3rGRg6Jm9QjFznMnA== X-CSE-MsgGUID: 1ypM+zCuTZyhao6v+RsE5g== X-IronPort-AV: E=McAfee;i="6700,10204,11328"; a="42105372" X-IronPort-AV: E=Sophos;i="6.13,238,1732608000"; d="scan'208";a="42105372" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2025 05:25:22 -0800 X-CSE-ConnectionGUID: oOw//HyuRH2sXbDiVD3/cA== X-CSE-MsgGUID: F7vXYkyrSx2N1gt4t3xT9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="131730368" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2025 05:25:02 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tcP6l-00000005jpm-3fIe; Mon, 27 Jan 2025 15:24:55 +0200 Date: Mon, 27 Jan 2025 15:24:55 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Michael Ellerman , Christophe Leroy , Damien Le Moal , Jiri Kosina , Greg Kroah-Hartman , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Tero Kristo , Stephen Boyd , Ian Abbott , H Hartley Sweeten , Srinivas Pandruvada , Len Brown , "Rafael J. Wysocki" , John Allen , Herbert Xu , Vinod Koul , Ard Biesheuvel , Bjorn Andersson , Moritz Fischer , Liviu Dudau , Benjamin Tissoires , Andi Shyti , Michael Hennerich , Peter Rosin , Lars-Peter Clausen , Jonathan Cameron , Dmitry Torokhov , Markuss Broks , Alexandre Torgue , Lee Jones , Jakub Kicinski , Shyam Sundar S K , Iyappan Subramanian , Yisen Zhuang , Stanislaw Gruszka , Kalle Valo , Sebastian Reichel , Tony Lindgren , Mark Brown , Alexandre Belloni , Xiang Chen , "Martin K. Petersen" , Neil Armstrong , Heiko Stuebner , Krzysztof Kozlowski , Vaibhav Hiremath , Alex Elder , Jiri Slaby , Jacky Huang , Helge Deller , Christoph Hellwig , Robin Murphy , Steven Rostedt , Masami Hiramatsu , Andrew Morton , Kees Cook , Trond Myklebust , Anna Schumaker , Masahiro Yamada , Nathan Chancellor , Takashi Iwai , linuxppc-dev@lists.ozlabs.org, linux-ide@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fpga@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rtc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, iommu@lists.linux.dev, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-hardening@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kbuild@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 00/34] address all -Wunused-const warnings Message-ID: References: <20240403080702.3509288-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-MailFrom: andriy.shevchenko@intel.com X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: F3FO4R57FOYKNQI27EHI5FHNEPXI2OIX X-Message-ID-Hash: F3FO4R57FOYKNQI27EHI5FHNEPXI2OIX X-Mailman-Approved-At: Mon, 17 Feb 2025 10:06:21 +0000 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 10:06:18AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compilers traditionally warn for unused 'static' variables, but not > if they are constant. The reason here is a custom for C++ programmers > to define named constants as 'static const' variables in header files > instead of using macros or enums. > > In W=1 builds, we get warnings only static const variables in C > files, but not in headers, which is a good compromise, but this still > produces warning output in at least 30 files. These warnings are > almost all harmless, but also trivial to fix, and there is no > good reason to warn only about the non-const variables being unused. > > I've gone through all the files that I found using randconfig and > allmodconfig builds and created patches to avoid these warnings, > with the goal of retaining a clean build once the option is enabled > by default. > > Unfortunately, there is one fairly large patch ("drivers: remove > incorrect of_match_ptr/ACPI_PTR annotations") that touches > 34 individual drivers that all need the same one-line change. > If necessary, I can split it up by driver or by subsystem, > but at least for reviewing I would keep it as one piece for > the moment. > > Please merge the individual patches through subsystem trees. > I expect that some of these will have to go through multiple > revisions before they are picked up, so anything that gets > applied early saves me from resending. Arnd, can you refresh this one? It seems some misses still... I have got 3+ 0-day reports against one of the mux drivers. https://lore.kernel.org/all/?q=adg792a.c -- With Best Regards, Andy Shevchenko