From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97920C77B61 for ; Tue, 25 Apr 2023 08:02:14 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9E6201060; Tue, 25 Apr 2023 10:01:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9E6201060 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682409731; bh=SXb9Vgkng76Dypcy0jYJIOd4e9GHPdXfEF8IIXWEOGY=; h=Date:From:To:Subject:References:In-Reply-To:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From; b=S4cTED/6giwHJFlPJ5ERGzRNA5TkvAg6RDC95BgK+hb3h+Kek7Op5FEXQYMyolSoI 33xDn/wyf67f38BwNuGa77uzgkXRdNvZEegGe18h6KqBwFWnXaGi7FglnG1tItC0iQ fPM9hIu7TqBN930/2ZJqzF7MeOC7lBB2utBw/Cw0= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8649DF8025E; Tue, 25 Apr 2023 10:00:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7788EF8025E; Tue, 25 Apr 2023 10:00:51 +0200 (CEST) Received: from bluemchen.kde.org (bluemchen.kde.org [IPv6:2001:470:142:8::100]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 945DEF800F8 for ; Tue, 25 Apr 2023 10:00:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 945DEF800F8 Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id 69C0124248; Tue, 25 Apr 2023 04:00:45 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1prDbR-oin-00; Tue, 25 Apr 2023 10:00:45 +0200 Date: Tue, 25 Apr 2023 10:00:45 +0200 From: Oswald Buddenhagen To: Takashi Iwai , alsa-devel@alsa-project.org, Jaroslav Kysela Subject: Re: [PATCH] ALSA: emu10k1: fix multi-channel playback device class Message-ID: Mail-Followup-To: Takashi Iwai , alsa-devel@alsa-project.org, Jaroslav Kysela References: <20230422161021.1143989-1-oswald.buddenhagen@gmx.de> <874jp7oy2k.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Message-ID-Hash: HCDXHRCU6CAMGAIRS7FYYXEZQF3PRDNE X-Message-ID-Hash: HCDXHRCU6CAMGAIRS7FYYXEZQF3PRDNE X-MailFrom: ossi@kde.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Apr 24, 2023 at 12:32:58PM +0200, Oswald Buddenhagen wrote: >so i'd postulate that these enums are effectively dead, and both the >risk and the gain of this change are about zero. speaking of dead code, lots of drivers explicitly assign info_flags = 0, dev_class = SNDRV_PCM_CLASS_GENERIC, and dev_subclass = SNDRV_PCM_SUBCLASS_GENERIC_MIX, which are all technically pointless, as the pcm struct is kzalloc'd anyway. and of course it's entirely inconsistent (with just about every combination present), because it obviously works without this. how would you feel about a patch that just removes all these? regards