From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BB14C77B75 for ; Wed, 3 May 2023 15:41:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EEC8710F4; Wed, 3 May 2023 17:40:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EEC8710F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683128489; bh=mx4NSQSFZxZH7LNLupsmO8efuuFMdxZthTu0nfY532g=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=USY5sxtD1pMnDDOHYG9TIIMv5sIk08OXGbe1JIoiYz8mO6LTXqkAjpWlBFwCSpYQd SnJvOKIfwKILhFTs0C9yrN5MOBpeb7noXi+rVSSHlxN8ACc0OakOXy3OA9nH2BJJ2q nUaEjJsnl3Rt5ybbpPpbEoliz8A9Czd/GWHmlkGk= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3319DF8032B; Wed, 3 May 2023 17:40:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E561EF8032B; Wed, 3 May 2023 17:40:07 +0200 (CEST) Received: from bluemchen.kde.org (bluemchen.kde.org [209.51.188.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 07188F800EC for ; Wed, 3 May 2023 17:40:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07188F800EC Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id 9E95624222; Wed, 3 May 2023 11:39:59 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1puEaF-tLD-00; Wed, 03 May 2023 17:39:59 +0200 Date: Wed, 3 May 2023 17:39:59 +0200 From: Oswald Buddenhagen To: Jaroslav Kysela Subject: Re: [PATCH alsa-lib 2/4] pcm: hw: add drain_silence configuration keyword Message-ID: Mail-Followup-To: Jaroslav Kysela , ALSA development References: <20230502115010.986325-1-perex@perex.cz> <20230502115010.986325-3-perex@perex.cz> <433f4a7c-a55b-6aa4-d2a3-100188c86960@perex.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <433f4a7c-a55b-6aa4-d2a3-100188c86960@perex.cz> Message-ID-Hash: T7Q52RXK3L4RINWIKB5QCVHAGL474SOA X-Message-ID-Hash: T7Q52RXK3L4RINWIKB5QCVHAGL474SOA X-MailFrom: ossi@kde.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ALSA development X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, May 03, 2023 at 04:22:03PM +0200, Jaroslav Kysela wrote: >On 03. 05. 23 13:24, Oswald Buddenhagen wrote: >> what i could imagine _hypothetically_ making sense is making the >> 1/10th >> sec "overshoot" configurable, as it's hardware-dependent. but in >> practice, i don't see how that would be actually useful, as the cost of >> doing too much is negligible, and the default you chose seems more than >> safe enough. > >The positive value is a bit bonus. I just picked an easy understandable way. >But looking to this issue for the second time, I changed the meaning for the >positive value to milliseconds. In this way, it's time/rate related. > i think it's a bad idea to add "bonus" features that have no clear use case. it's basically dead code, and you can't use these values for something actually useful later. >Thanks for the review of all patches - I picked some proposals and >pushed changes to the alsa-lib repository: > well, and you ignored some of them for no obvious reason. generally, i don't think maintainers should be exempt from replying to comments and posting v2+ patchsets. regards