From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46C14C77B7D for ; Thu, 18 May 2023 14:00:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 28F07204; Thu, 18 May 2023 15:59:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 28F07204 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684418421; bh=kMIEJWGK5qDMqAB6VXsC7mtm3k5yTUmyxHlS0FRCZaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=WF3Sw5TZDHC0PsycSBS4IuepfNLv5Scx2dBgT9edrgNBiPE98HaA0FZwVMU+KgwSo uI9VjaWmxYwBV96oqW7wUCye0JnPmf+KXrd7xys+LBw1zlt+AIP7CbyOquupcbMbcJ DCEhg5ubaCBqEugtAwiBp0xIvLuxd2jFTsk+H5IE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E8668F80549; Thu, 18 May 2023 15:59:00 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 68D57F80272; Thu, 18 May 2023 15:59:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 361E6F80272; Thu, 18 May 2023 15:58:57 +0200 (CEST) Received: from bluemchen.kde.org (bluemchen.kde.org [IPv6:2001:470:142:8::100]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0DCDF8016D for ; Thu, 18 May 2023 15:58:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B0DCDF8016D Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id 7CE4523E25; Thu, 18 May 2023 09:58:51 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1pze9b-cDb-00; Thu, 18 May 2023 15:58:51 +0200 Date: Thu, 18 May 2023 15:58:51 +0200 From: Oswald Buddenhagen To: Tom Rix Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static Message-ID: Mail-Followup-To: Tom Rix , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20230518123826.925752-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20230518123826.925752-1-trix@redhat.com> Message-ID-Hash: PZPLLEN4ZYHLH3RAQZ2SD2B5APCCPKXA X-Message-ID-Hash: PZPLLEN4ZYHLH3RAQZ2SD2B5APCCPKXA X-MailFrom: ossi@kde.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote: >smatch reports ^^^^^^ is this the best word to use here? >sound/pci/emu10k1/emumixer.c:519:39: warning: symbol > 'emu1010_routing_info' was not declared. Should it be static? >sound/pci/emu10k1/emumixer.c:859:36: warning: symbol > 'emu1010_pads_info' was not declared. Should it be static? > >These variables are only used in their defining file, so it should be static ^^ they > >Signed-off-by: Tom Rix > Reviewed-by: Oswald Buddenhagen (also amending one of the still pending patches. thanks!) regards