From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 231C3C77B7A for ; Fri, 19 May 2023 10:45:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4282F204; Fri, 19 May 2023 12:44:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4282F204 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684493098; bh=yFshGwXhhuKSFJBaKJHS3YynRWuQTIGkK7oZ/WIAJDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=J+0hWcpjE1db8Z6fPiItpmFyLFIiRfNNHRu0837+zEVSCzXE8FP2HkPwQc4HkdqXx 5Wz1J4evvoT+qJO0SdqNQTFSbMvueqAcI2C+cu/eeiYfyzA1lumo/P/I1KVytFgxIJ eBOzCUCo2hCjxO+Ijwm+piMPOb5VfpJ8PSYl3H6M= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D24A3F80542; Fri, 19 May 2023 12:43:40 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2B518F80272; Fri, 19 May 2023 12:43:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D987CF80272; Fri, 19 May 2023 12:43:33 +0200 (CEST) Received: from bluemchen.kde.org (bluemchen.kde.org [IPv6:2001:470:142:8::100]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7CA73F8024E for ; Fri, 19 May 2023 12:43:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7CA73F8024E Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id C93A923F20; Fri, 19 May 2023 06:43:24 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1pzxa0-okg-00; Fri, 19 May 2023 12:43:24 +0200 Date: Fri, 19 May 2023 12:43:24 +0200 From: Oswald Buddenhagen To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Jaroslav Kysela Subject: Re: [PATCH 5/7] ALSA: emu10k1: centralize freeing PCM voices Message-ID: References: <20230518140947.3725394-1-oswald.buddenhagen@gmx.de> <20230518140947.3725394-6-oswald.buddenhagen@gmx.de> <87ttw9hesg.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87ttw9hesg.wl-tiwai@suse.de> Message-ID-Hash: BLMNG4WDGJ4N3AB64ELAJGADS53CXEWV X-Message-ID-Hash: BLMNG4WDGJ4N3AB64ELAJGADS53CXEWV X-MailFrom: ossi@kde.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, May 18, 2023 at 04:53:19PM +0200, Takashi Iwai wrote: >On Thu, 18 May 2023 16:09:45 +0200, >Oswald Buddenhagen wrote: >> -static int snd_emu10k1_pcm_channel_alloc(struct snd_emu10k1_pcm * epcm, int voices) >> +static void snd_emu10k1_pcm_free_voices(struct snd_emu10k1_pcm *epcm) >> { >> - int err, i; >> - >> - for (i = 0; i < ARRAY_SIZE(epcm->voices); i++) { >> + for (unsigned i = 0; i < ARRAY_SIZE(epcm->voices); i++) { > >We don't use this style. Declare the variable outside the for(). > ehm ... - "we" seems to be mostly true for alsa. but looking at the kernel as a whole, that ship has sailed since the adoption of c11. maybe time to adapt? - you're noticing this a bit late, after already merging 8 instances. how should i proceed? >Also, as usual, it'd be still helpful if you show this is merely a >code simplification without any functional change in the commit log. > right. i don't always remember to pre-emptively amend the patches i wrote quite a while ago ... regards