From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02172EB64DD for ; Thu, 29 Jun 2023 14:45:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 71176825; Thu, 29 Jun 2023 16:45:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 71176825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688049953; bh=l6/fsB8WyUAC8c3jQmgFNRD0AvMmRQIcX4wvRqe5bAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=lbfwreZyLEg542AhMjZQeCNWyc7WGtjUeoni9zYQREYHfUtkGY8s3JjCFWMrn27NT T8wbwcr6u8BHxAFb4Aw2so0SKa5AkmcYyTNyqHkathHeB6G5u8CEChSsDMCzdQVqAa 8wC4LyxSiqtsmo0P9LL+MsbuqrjYsBDkHTCVPYI0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id DD16FF80544; Thu, 29 Jun 2023 16:44:37 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6C46EF80169; Thu, 29 Jun 2023 16:44:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 403F2F80246; Thu, 29 Jun 2023 16:44:34 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DB6ACF80169 for ; Thu, 29 Jun 2023 16:44:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DB6ACF80169 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=cBstBS0y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688049869; x=1719585869; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=l6/fsB8WyUAC8c3jQmgFNRD0AvMmRQIcX4wvRqe5bAo=; b=cBstBS0yGYxkSVm40VqLal05nzr9XyVOsrLmLadq2obUb8tono7/DO8s q+/zC9ej3siDUjMckggqdv7aj4rwxnUWbWdqUqEJOKV+Noqevdc+YFD2U IMns1spu7HftRoXkdHTHKdkyVYlNOYpchyEYMqnl9VgLgVADcI2mmFsh3 9aZKQk3TuAuf/BBrEeilenN69opnN7aQTHgtVaCESCzafbwobfnSYoE7d 03LU7OHcdzFwSB5MNDUqKOBFCjWf+29zkERiDY2Tn9aaAklV6/rEvxEfd Wgq5tBfQ9yUtMC+zNBboGXh9tXv6OqvUY3Cw3FK1+nQZwgqNCl+m4hRIy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="392848652" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="392848652" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 07:44:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="667555125" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="667555125" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 29 Jun 2023 07:44:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qEssK-000sk9-2D; Thu, 29 Jun 2023 17:44:00 +0300 Date: Thu, 29 Jun 2023 17:44:00 +0300 From: Andy Shevchenko To: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 1/3] ASoC: rt5677: Use agnostic irq_domain_create_linear() Message-ID: References: <20230629104603.88612-1-andriy.shevchenko@linux.intel.com> <20230629104603.88612-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629104603.88612-2-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: HAEE6C7RVRE4ETVP2EKX4CRDSZIXJNFH X-Message-ID-Hash: HAEE6C7RVRE4ETVP2EKX4CRDSZIXJNFH X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Jun 29, 2023 at 01:46:01PM +0300, Andy Shevchenko wrote: > Instead of irq_domain_add_linear() that requires of_node, > use irq_domain_create_linear() that works outside of OF world. ... > - rt5677->domain = irq_domain_add_linear(i2c->dev.of_node, > + rt5677->domain = irq_domain_create_linear(dev_fwnode(i2c->dev), > RT5677_IRQ_NUM, &rt5677_domain_ops, rt5677); Oops, this won't compile :-( Seems I tried in another branch that has this module disabled. > if (!rt5677->domain) { > dev_err(&i2c->dev, "Failed to create IRQ domain\n"); -- With Best Regards, Andy Shevchenko