From: Vinod Koul <vkoul@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Sanyog Kale" <sanyog.r.kale@intel.com>,
"Vijendar Mukunda" <Vijendar.Mukunda@amd.com>,
"Rander Wang" <rander.wang@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soundwire: intel_ace2x: fix SND_SOC_SOF_HDA_MLINK dependency
Date: Wed, 21 Jun 2023 16:21:15 +0530 [thread overview]
Message-ID: <ZJLWIw5nMhFcaoSe@matsya> (raw)
In-Reply-To: <20230616090932.2714714-1-arnd@kernel.org>
On 16-06-23, 11:09, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The ace2x driver can be build with or without mlink support, but
> when SND_SOC_SOF_HDA_MLINK is set to =m and soundwire is built-in,
> it fails with a link error:
>
> ld.lld: error: undefined symbol: hdac_bus_eml_sdw_wait_syncpu_unlocked
> >>> referenced by intel_ace2x.c
> >>> drivers/soundwire/intel_ace2x.o:(intel_link_power_up) in archive vmlinux.a
>
> ld.lld: error: undefined symbol: hdac_bus_eml_sdw_sync_arm_unlocked
> >>> referenced by intel_ace2x.c
> >>> drivers/soundwire/intel_ace2x.o:(intel_sync_arm) in archive vmlinux.a
>
> Add a Kconfig dependency that prevents that broken configuration but
> still allows soundwire to be a loadable module instead.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2023-06-21 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:09 [PATCH] soundwire: intel_ace2x: fix SND_SOC_SOF_HDA_MLINK dependency Arnd Bergmann
2023-06-21 10:51 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJLWIw5nMhFcaoSe@matsya \
--to=vkoul@kernel.org \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox