From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DF44EB64D7 for ; Wed, 28 Jun 2023 14:53:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E23AC843; Wed, 28 Jun 2023 16:52:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E23AC843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1687964017; bh=uHOo6pxeJDOU50rDEZZ8nkN2xnoOZoCUvC36LEG0P48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FepI0dSi0jh/xRZoR2zJ7Xy5DDFuNFod0/yECx8qVlswu6J+vu+a21roGXXLadYl9 IXYdzDWFoOlQFautSXeYdSFy84mh+R+HI6bJv4m9ikyYfDmAMNYLrE7zEz7vJZl9nn M675jvTDmleJfe1NOo8STJswMCOSAZESCEuRPV5Y= Received: by alsa1.perex.cz (Postfix, from userid 50401) id ADA0DF80544; Wed, 28 Jun 2023 16:52:46 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1DA75F8027B; Wed, 28 Jun 2023 16:52:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 65B88F8027B; Wed, 28 Jun 2023 16:52:43 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 43AFBF80169 for ; Wed, 28 Jun 2023 16:52:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 43AFBF80169 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Cw0Iw2fj DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687963962; x=1719499962; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uHOo6pxeJDOU50rDEZZ8nkN2xnoOZoCUvC36LEG0P48=; b=Cw0Iw2fjtZScGnUIOsYQwrOXWl011blhs+4Y0qqF5PIGbca/9YaemkAH gah2yUQQO/aMnsd1d5u9CvqsBcgEwFpRtyhIfGZJ0MVicIt2DwnJT7fhs 7BnXmBtU5/zjZqSAdRmIPCg6wiG+IYcvLpQ6pL471EShkW75Wa6OadUQm iLxboh7Mfd9xlBd9u3O/dxlqMJhlyDaJM4G6ajUAqUFL8bUcQUhHmzxmf 7MBeLVRDBis0VOKfqMwyelAghmJIM4ZVLmWzixJC/wdgoX113RLjvor/c Eiom40i0Vt+VZ/HIfLIW5D1hTnNab3RzT1YkpCCmunNY7Aighi02qAkbA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="342201919" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="342201919" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2023 07:52:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="720261514" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="720261514" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 28 Jun 2023 07:52:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qEWX4-000cxD-1u; Wed, 28 Jun 2023 17:52:34 +0300 Date: Wed, 28 Jun 2023 17:52:34 +0300 From: Andy Shevchenko To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen Subject: Re: [RFC PATCH 7/8] ASoC: Intel: Skylake: Update PCI ID list Message-ID: References: <20230628205135.517241-1-amadeuszx.slawinski@linux.intel.com> <20230628205135.517241-8-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230628205135.517241-8-amadeuszx.slawinski@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: HX6Y5MQCGV3U52UPKFXYT32KY6KNGDDX X-Message-ID-Hash: HX6Y5MQCGV3U52UPKFXYT32KY6KNGDDX X-MailFrom: andriy.shevchenko@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Jun 28, 2023 at 10:51:34PM +0200, Amadeusz Sławiński wrote: > Use PCI device IDs from pci_ids.h header and while at it change to using > PCI_DEVICE_DATA macro, to simplify declarations. PCI_DEVICE_DATA() ... > + { PCI_DEVICE_DATA(INTEL, HDA_SKL_LP, &snd_soc_acpi_intel_skl_machines) }, Do you really need TAB(s) in the parameter list? -- With Best Regards, Andy Shevchenko