From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D21AEB64DD for ; Thu, 13 Jul 2023 10:55:46 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 49990210; Thu, 13 Jul 2023 12:54:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 49990210 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689245743; bh=U+uXS9v2Wp//H2UltV0PTn2glWkJwIcxBA0w92cxioQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ha+oUn4gTbKkidC5ShFJ+YS8CbOmPF9dIy8RUCuVXhyF8iCpkVW/gIBUMoMetmR+n K7Uoooy1z9TAGAlNa/rCshg2Afkqto6aXAUFWpL7TdLjhc/UTDQ/e8P1qJ5Y76si/v yizmlYj1XpTJAxIkcTmtHacBH4hahkx0DMuhpW1U= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C408FF8027B; Thu, 13 Jul 2023 12:54:26 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 51E6CF80249; Thu, 13 Jul 2023 12:54:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A9BF5F80249; Thu, 13 Jul 2023 12:54:21 +0200 (CEST) Received: from bluemchen.kde.org (bluemchen.kde.org [209.51.188.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3A047F800E4 for ; Thu, 13 Jul 2023 12:54:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3A047F800E4 Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id 42D0E23E74; Thu, 13 Jul 2023 06:54:12 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.6-dev, from userid 1000) id 1qJtxb-kBa-00; Thu, 13 Jul 2023 12:54:11 +0200 Date: Thu, 13 Jul 2023 12:54:11 +0200 From: Oswald Buddenhagen To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Jaroslav Kysela Subject: Re: [PATCH 3/3] ALSA: emu10k1: (re-)add mixer locking Message-ID: References: <20230712145750.125086-1-oswald.buddenhagen@gmx.de> <20230712145750.125086-3-oswald.buddenhagen@gmx.de> <87jzv4fbxl.wl-tiwai@suse.de> <87edlcf9p9.wl-tiwai@suse.de> <875y6of6sj.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <875y6of6sj.wl-tiwai@suse.de> Message-ID-Hash: INRHPKZZXD35OWPLNWAEEERKJWYEJEEF X-Message-ID-Hash: INRHPKZZXD35OWPLNWAEEERKJWYEJEEF X-MailFrom: ossi@kde.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Jul 13, 2023 at 12:24:28PM +0200, Takashi Iwai wrote: >Well, I took your patch 3 just because you wanted to have a protection >of your data from both get/put callback and from another code path in >another patch. It was an (ab)use of controls->rwsem that couldn't be >accepted, so the patch 3 was taken as an alternative. > >If this isn't the scenario, let me know: I'd rather drop the patch >again, as it's superfluous. > ok, then please drop it. you're quite right that this is the scenario, but i can do that selectively just as well, like it already is the case in some other callbacks. i just wanted to have this patch first if it was to be applied at all, because it seemed cleaner. regards