From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C040EB64DC for ; Tue, 11 Jul 2023 14:26:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8A065ECA; Tue, 11 Jul 2023 16:25:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8A065ECA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689085565; bh=pnPOejrtBmciSuneX2GIuca/d8m7aJiJ68yCzAIAa8Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=n8Q8ssCDf/k9EigCltXFHBpsQORmDrAcs8Xba9CvqfGNOHOBrAUbXYMMwcJ45IFqC GjkPJd9Cnqaac33n1xh5L4F/UyxPltCyV++6jq67jOOv0wSC4BoV3r7W2OPNxORVUC ZOHfm1IiEyIiIFDfr1rE3/8kNd8ktpwZVixvJhxA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C8458F80603; Tue, 11 Jul 2023 16:22:01 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2498EF80611; Tue, 11 Jul 2023 16:22:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 735A7F80236; Tue, 11 Jul 2023 13:10:25 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5CB01F80093 for ; Tue, 11 Jul 2023 13:10:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5CB01F80093 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=A4EDmKzZ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689073823; x=1720609823; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pnPOejrtBmciSuneX2GIuca/d8m7aJiJ68yCzAIAa8Y=; b=A4EDmKzZe+xrgH16GDyEiKso/+66cyUM+qvWtfRtUWJdIeU4oxxZX7kO rCKfQ9xlL6om0o0oxaAE9a4fYXixaw5W32oOIJGdugg7HiWteA02js4yp FdPImtGPGwd8fnHcWX9t4ijI1UGFgZy0eTfuThDdWR/iEU7BMDMyNtGZz kj55+2eSgz0zB/XVe4n2SlQozvnL33h+6PcYKFoFG8eDgkbmbxpqABdgg k2YH4H3plI2kT+mxj9Lm3lErROZ6wqedDAB5iBZx+1aqEup6JyqBVsoor MLQhK4D9hhmmwH049UD9l7PkV2K0q242QiOfYclVwulyxadcl49dgl9R/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="344909470" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="344909470" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 04:10:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="834644461" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="834644461" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 11 Jul 2023 04:10:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJBFs-001pGf-16; Tue, 11 Jul 2023 14:10:04 +0300 Date: Tue, 11 Jul 2023 14:10:04 +0300 From: Andy Shevchenko To: Mark Brown Cc: Cristian Ciocaltea , Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Neil Armstrong , Tharun Kumar P , Vijaya Krishna Nivarthi , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Sanjay R Mehta , Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Serge Semin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Steven Rostedt , Masami Hiramatsu , Richard Cochran Subject: Re: [PATCH v2 08/15] spi: Clean up headers Message-ID: References: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> <20230710154932.68377-9-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: HLHY2MGN7JUSCIYWEDPHHDJMOTB7ZCDS X-Message-ID-Hash: HLHY2MGN7JUSCIYWEDPHHDJMOTB7ZCDS X-Mailman-Approved-At: Tue, 11 Jul 2023 14:21:48 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jul 11, 2023 at 09:26:46AM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 06:49:25PM +0300, Andy Shevchenko wrote: > > There is a few things done: > > - include only the headers we are direct user of > > - when pointer is in use, provide a forward declaration > > - add missing headers > > - group generic headers and subsystem headers > > - sort each group alphabetically > > This breaks an x86 allmodconfig build: Yeah, it was too brave to go. That's actually the answer why I left mod_devicetable.h included. (However the mod_devicetable.h probably should stay to be similar to i2c.h. Let's postpone this one, but it's good to have the build report so we know which drivers are missing GPIO header to be included. -- With Best Regards, Andy Shevchenko